Opened 12 years ago

Closed 12 years ago

Last modified 2 years ago

#8933 closed patch

ARCHIVE: New method 'getMember'

Reported by: lordhoto Owned by: lordhoto
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

Hi,

after talking with peres we both agreed, that a new method 'getFile', which unlike 'openFile' returns a ArchiveMember representation of a given file, might be a handy feature. This patch implements a 'getFile' for all Archives and changes Kyra to use it.

What I'm unsure about: Peres suggested we could implement a default 'openFile' now via 'getFile', but then we would break GenericArchiveMember, since it requires a working Archive::openFile. So I don't really think it's a good idea.

// Johannes

Ticket imported from: #2207782. Ticket imported from: patches/1038.

Attachments (1)

archive_getfile_v1.patch (7.1 KB ) - added by lordhoto 12 years ago.
Patch against r34861.

Download all attachments as: .zip

Change History (4)

by lordhoto, 12 years ago

Attachment: archive_getfile_v1.patch added

Patch against r34861.

comment:1 by lordhoto, 12 years ago

Committed with a slight change: Renamed getFile to getMember.

comment:2 by lordhoto, 12 years ago

Owner: changed from peres to lordhoto
Status: newclosed
Summary: ARCHIVE: New method 'getFile'ARCHIVE: New method 'getMember'

comment:3 by digitall, 2 years ago

Component: --Other--
Note: See TracTickets for help on using tickets.