Opened 16 years ago

Closed 16 years ago

Last modified 5 years ago

#8868 closed patch

HoF: Hand of Fate credits cleanup (WIP)

Reported by: eriktorbjorn Owned by: athrxx
Priority: normal Component: Engine: Kyra
Version: Keywords:
Cc: Game: Kyrandia 2


This is a first attempt at cleaning up the code that displays the scrolling credits text in Hand of Fate. I don't have the time to look any further at it at the moment. Maybe someone else would like to comment on it, and perhaps improve it. (It seems to work, but...)

The background to this patch is that I wanted to fix a glitch in the credits scroll (the topmost line simply vanishes, rather than scrolling off the screen), but found the code too hard to read.

Basically, what I've done is to replace the tmp[] byte array with an array of structs.

Ticket imported from: #1964853. Ticket imported from: patches/973.

Attachments (1)

kyra2-credits.diff (4.9 KB ) - added by eriktorbjorn 16 years ago.
Patch against current SVN

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 16 years ago

Attachment: kyra2-credits.diff added

Patch against current SVN

comment:1 by lordhoto, 16 years ago

Owner: set to lordhoto

comment:2 by lordhoto, 16 years ago

Owner: changed from lordhoto to athrxx

comment:3 by athrxx, 16 years ago

committed with some changes and with a fix for that glitch (signed/unsigned bug).

Thanks a lot for your efforts (the code was admittedly not much fun to read :-) ).

comment:4 by athrxx, 16 years ago

Status: newclosed

comment:5 by digitall, 5 years ago

Component: Engine: Kyra
Game: Kyrandia 2
Note: See TracTickets for help on using tickets.