Opened 12 years ago

Closed 12 years ago

Last modified 19 months ago

#8852 closed patch (outdated)

KYRA: MT-32 support

Reported by: lordhoto Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game:

Description

Hi,

here's initial MT-32 support for the Kyrandia engine. I posted this on the patch tracker for some reasons:

1) I changed sound/mididrv.h, updated maximal SysEx size there

2) I changed all midi drivers supporting it (at least in backends/midi)

3) HoF midi got some problems when using SFX, it seems like it's caused by double channel usage. For example when playing a sfx parts of the background music stop for some seconds.

4) MT-32 initialization is not that nice done in engines/kyra/sound.cpp SoundMidiPC::init right now, since a) it uses hardcoded sound file and archive filenames b) it lacks text support for Kyra1 c) I'm not sure but Kyra2 had some MT-32 init code showing text for the intro executable too, that has to be investigated

Apart from that Kyra1 works fine for me, also most Kyra2 music does, just some 'action' music when using guitar sounds pretty strange but maybe that's the same in the original.

Ticket imported from: #1938026. Ticket imported from: patches/957.

Attachments (1)

kyra_mt32.patch (18.5 KB ) - added by lordhoto 12 years ago.
Patch against r31450

Download all attachments as: .zip

Change History (7)

by lordhoto, 12 years ago

Attachment: kyra_mt32.patch added

Patch against r31450

comment:1 by lordhoto, 12 years ago

Owner: set to lordhoto

comment:2 by sev-, 12 years ago

Johannes, may be just commit it as is?

comment:3 by lordhoto, 12 years ago

Actually I don't know if it still applies. Also It's really not that good working, so I wouldn't like to commit it.

comment:4 by lordhoto, 12 years ago

Since I fixed MIDI in KYRA now, I'll close this one.

comment:5 by lordhoto, 12 years ago

Resolution: outdated
Status: newclosed

comment:6 by digitall, 19 months ago

Component: Engine: Kyra
Note: See TracTickets for help on using tickets.