Opened 12 years ago

Closed 12 years ago

Last modified 20 months ago

#8849 closed patch

HashMap: Iterator rework

Reported by: lordhoto Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

Hi,

again a little patch which reintroduced the usage of a template for Iterator which should get rid of the code duplication for the iterator code. This time I used a template<class T> friend so it compiles fine on gcc 4.1 etc. also. I currently do not know about gcc 2.95, *maybe* we would need to add some ifdef hackery there, which maybe includes making some hashmap members public for that compiler, but I think it is nicer than the code duplication.

Ticket imported from: #1929274. Ticket imported from: patches/954.

Attachments (2)

hashmap.patch (4.3 KB ) - added by lordhoto 12 years ago.
patch against SVN before MemoryPool addition
hashmap_v2.patch (17.7 KB ) - added by lordhoto 12 years ago.
patch against current svn

Download all attachments as: .zip

Change History (8)

by lordhoto, 12 years ago

Attachment: hashmap.patch added

patch against SVN before MemoryPool addition

comment:1 by lordhoto, 12 years ago

Owner: set to fingolfin

by lordhoto, 12 years ago

Attachment: hashmap_v2.patch added

patch against current svn

comment:2 by lordhoto, 12 years ago

File Added: hashmap_v2.patch

comment:3 by lordhoto, 12 years ago

Ok according to Begasus it compiled fine on gcc 2.95.

comment:4 by lordhoto, 12 years ago

Ops just noticed I included some changes to my local tree not related to the patch in the latest patchfile. Committed now with just the hashmap changes.

comment:5 by lordhoto, 12 years ago

Status: newclosed

comment:6 by digitall, 20 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.