Opened 13 years ago

Closed 12 years ago

Last modified 12 months ago

#8627 closed patch

BASS: Update the cursor when right-clicking in inventory

Reported by: jvprat Owned by: fingolfin
Priority: normal Component: Engine: Sky
Keywords: Cc:
Game: Beneath a Steel Sky

Description

When right-clicking on an item on the inventory, the mouse cursor isn't updating until the mouse moves outside the item. It seems it's the same thing the original interpreter did (as it's managed by scripts).

It's specially annoying when playing BASS in a touch-screen (in particular in the LINC interface), because the cursor always shows the last selected object, not the current one (it detects movement just before selecting a new item).

The attached patch just updates the mouse cursor when it detects a right-click on an inventory item, giving a much more intuitive behavior (instant reaction).

Ticket imported from: #1689516. Ticket imported from: patches/732.

Attachments (4)

inventory_cursor.patch (703 bytes ) - added by jvprat 13 years ago.
Update the mouse cursor when changing selection in inventory
inventory_cursor_updated.patch (664 bytes ) - added by jvprat 13 years ago.
Updated patch: Update the cursor with both right and left clicks (for the LINC interface)
inventory_cursor_final.patch (725 bytes ) - added by jvprat 12 years ago.
Updated patch: Now it really works in LINC
bass-saves.tgz (69.1 KB ) - added by jvprat 12 years ago.
Savegames to test the LINC interface

Download all attachments as: .zip

Change History (20)

by jvprat, 13 years ago

Attachment: inventory_cursor.patch added

Update the mouse cursor when changing selection in inventory

comment:1 by jvprat, 13 years ago

I've just realised that in the LINC interface, the cursor should also be updated with left-clicks. I'll update the patch in a few.

comment:2 by jvprat, 13 years ago

I've just realised that in the LINC interface, the cursor should also be updated with left-clicks. I'll update the patch in a few.

by jvprat, 13 years ago

Updated patch: Update the cursor with both right and left clicks (for the LINC interface)

comment:3 by jvprat, 13 years ago

File Added: inventory_cursor_updated.patch

comment:4 by fingolfin, 13 years ago

I am not sure whether this change is "safe". Anybody?

comment:5 by fingolfin, 13 years ago

Owner: set to joostp

by jvprat, 12 years ago

Updated patch: Now it really works in LINC

comment:6 by jvprat, 12 years ago

I'm attaching an updated and (hopefully) complete patch. I didn't test it before in LINC, it just fixed the "normal" interface. It shows a consistent behavior now.
File Added: inventory_cursor_final.patch

by jvprat, 12 years ago

Attachment: bass-saves.tgz added

Savegames to test the LINC interface

comment:7 by jvprat, 12 years ago

I'm attaching savegames so you can go directly to LINC to test it.
File Added: bass-saves.tgz

comment:8 by fingolfin, 12 years ago

Owner: changed from joostp to cyxx

comment:9 by fingolfin, 12 years ago

Well it's mainly a question of finding a BASS "expert" who's willing to look into this. But if neither Robert or Joost have time to look into this, I guess I'll apply this on sunday or so.

comment:10 by cyxx, 12 years ago

I think this should have been assigned to Robert rather than me :)

comment:11 by cyxx, 12 years ago

Owner: changed from cyxx to lavosspawn

comment:12 by fingolfin, 12 years ago

What is the status of this item?

comment:13 by jvprat, 12 years ago

If you need something else from me just let me know (a video showing the behavior change in a touchscreen device, playing the full game again to see whether there are no regressions, etc.)

comment:14 by fingolfin, 12 years ago

Owner: changed from lavosspawn to fingolfin
Status: newclosed

comment:15 by fingolfin, 12 years ago

I have just applied this patch. Sadly, I didn't think of applying this a month ago, else it would have come into 0.11.0. As it is, I am not sure I really should add this into a frozen branch, as it still might introduce regressions...
But it's in the trunk now, at least!

comment:16 by digitall, 12 months ago

Component: Engine: Sky
Game: Beneath a Steel Sky
Note: See TracTickets for help on using tickets.