Opened 13 years ago

Closed 13 years ago

Last modified 10 months ago

#8574 closed patch

ScummVM DS changes for branch 0-9-0

Reported by: agent-q Owned by: agent-q
Priority: normal Component: Port: NDS
Keywords: Cc:
Game:

Description

This is a patch containing all the changes necessary to
support ScummVM DS in the 0-9-0 branch.

The backend is not included, I will check that in once
these chances are integrated.

As far as I remember, all the changes are already in
the truck except for the ones to simon.cpp.

Ticket imported from: #1564147. Ticket imported from: patches/679.

Attachments (2)

scummvmds_090_branch.patch (12.5 KB) - added by agent-q 13 years ago.
DS port codebase changes
themeclassic_restorebackground.patch (565 bytes) - added by agent-q 13 years ago.
Patch to fix background refresh glitches when CT_NO_TRANSPARENCY is used

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by agent-q

Attachment: scummvmds_090_branch.patch added

DS port codebase changes

comment:1 Changed 13 years ago by sev-

In my opinion all of the changes are safe. Those are
substitutions of some function with their ARM version (via
proper #ifdefs), some more #ifdefs and itroduction of
virtual function setFocusRectangle to OSystem with empty
default implementation. I.e. it does not affect other ports.

Neil, besides, one question. Why thumbnails are disabled in
your port? Because of additional size?

comment:2 Changed 13 years ago by fingolfin

Looks good to me, too.

comment:3 Changed 13 years ago by agent-q

Yes, the thumbnails add a lot to the size of the saves and
they are not displayed on the classic theme (as far as I can
see) so there's nothing lost in not using them.

In trying to improve the GUI performance I enabled
CT_NO_TRANSPARENCY, and I think I have found another bug. I
have attached another small patch to one file that fixes it
for me. I'm not really sure why it works so you may want to
give it a look.

Changed 13 years ago by agent-q

Patch to fix background refresh glitches when CT_NO_TRANSPARENCY is used

comment:4 Changed 13 years ago by fingolfin

OK, so how about just applying the first patch right now? Or are sev or me
expected to do it?

I just don't want that we are waiting forever for the other to do something... :-)

comment:5 Changed 13 years ago by agent-q

Sorry, I thought one of the higher-ups had to do it. I'll
commit the changes this evening when I get home.

comment:6 Changed 13 years ago by fingolfin

What is the status of this item?

comment:7 Changed 13 years ago by agent-q

The first patch is committed, the second one doesn't really
fix the problem, but I don't have a better solution. Since
it's not really a fix, I haven't applied it.

comment:8 Changed 13 years ago by sev-

What is the status of this item?

comment:9 Changed 13 years ago by agent-q

It's resolved. The frontend patch caused more problems than
it solved so I didn't put it in. I should probably have a
go at fixing the issue in the trunk.

comment:10 Changed 13 years ago by agent-q

Resolution: fixed

comment:11 Changed 13 years ago by sev-

Owner: set to agent-q
Resolution: fixed
Status: newclosed

comment:12 Changed 10 months ago by digitall

Component: Port: NDS
Note: See TracTickets for help on using tickets.