#8574 closed patch
ScummVM DS changes for branch 0-9-0
| Reported by: | agent-q | Owned by: | agent-q |
|---|---|---|---|
| Priority: | normal | Component: | Port: NDS |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This is a patch containing all the changes necessary to support ScummVM DS in the 0-9-0 branch.
The backend is not included, I will check that in once these chances are integrated.
As far as I remember, all the changes are already in the truck except for the ones to simon.cpp.
Ticket imported from: #1564147. Ticket imported from: patches/679.
Attachments (2)
Change History (14)
by , 18 years ago
| Attachment: | scummvmds_090_branch.patch added |
|---|
comment:1 by , 18 years ago
In my opinion all of the changes are safe. Those are substitutions of some function with their ARM version (via proper #ifdefs), some more #ifdefs and itroduction of virtual function setFocusRectangle to OSystem with empty default implementation. I.e. it does not affect other ports.
Neil, besides, one question. Why thumbnails are disabled in your port? Because of additional size?
comment:3 by , 18 years ago
Yes, the thumbnails add a lot to the size of the saves and they are not displayed on the classic theme (as far as I can see) so there's nothing lost in not using them.
In trying to improve the GUI performance I enabled CT_NO_TRANSPARENCY, and I think I have found another bug. I have attached another small patch to one file that fixes it for me. I'm not really sure why it works so you may want to give it a look.
by , 18 years ago
| Attachment: | themeclassic_restorebackground.patch added |
|---|
Patch to fix background refresh glitches when CT_NO_TRANSPARENCY is used
comment:4 by , 18 years ago
OK, so how about just applying the first patch right now? Or are sev or me expected to do it?
I just don't want that we are waiting forever for the other to do something... :-)
comment:5 by , 18 years ago
Sorry, I thought one of the higher-ups had to do it. I'll commit the changes this evening when I get home.
comment:7 by , 18 years ago
The first patch is committed, the second one doesn't really fix the problem, but I don't have a better solution. Since it's not really a fix, I haven't applied it.
comment:9 by , 18 years ago
It's resolved. The frontend patch caused more problems than it solved so I didn't put it in. I should probably have a go at fixing the issue in the trunk.
comment:10 by , 18 years ago
| Resolution: | → fixed |
|---|
comment:11 by , 18 years ago
| Owner: | set to |
|---|---|
| Resolution: | fixed |
| Status: | new → closed |
comment:12 by , 6 years ago
| Component: | → Port: NDS |
|---|
DS port codebase changes