Opened 13 years ago

Closed 13 years ago

Last modified 9 months ago

#8556 closed patch

Amiga version tag

Reported by: SF/polluks Owned by: fingolfin
Priority: normal Component: Port: AmigaOS4
Keywords: Cc:
Game:

Description

--- base/version.cpp.bak Wed Jun 21 21:17:37 2006
+++ base/version.cpp Fri Jul 14 01:01:05 2006
@@ -57,8 +57,8 @@
*/
const char *gScummVMVersion = SCUMMVM_VERSION;
const char *gScummVMBuildDate = __DATE__ " " __TIME__;
-const char *gScummVMVersionDate = SCUMMVM_VERSION " ("
__DATE__ " " __TIME__ ")";
-const char *gScummVMFullVersion = "ScummVM "
SCUMMVM_VERSION " (" __DATE__ " " __TIME__ ")";
+const char *gScummVMFullVersion = "$VER: ScummVM "
SCUMMVM_VERSION " (" __DATE__ " " __TIME__ ")" + sizeof
"$VER:";
+const char *gScummVMVersionDate = gScummVMFullVersion
+ sizeof "ScummVM";
const char *gScummVMFeatures = ""
#ifdef USE_TREMOR
"Tremor "

Ticket imported from: #1524702. Ticket imported from: patches/661.

Attachments (1)

version.cpp.patch (680 bytes) - added by SF/polluks 13 years ago.
transparent Amiga version tag

Download all attachments as: .zip

Change History (16)

comment:1 Changed 13 years ago by fingolfin

Ah come on, you should be able to at least write a single sentence explaining
the purpose of your patch. And attach the patch as a file, so that it can be
applied / reviewed properly.

Submitting patches w/o any comment or explanation is a waste of time for the
patch reviewer, and such patches end up in the garbage bin more often than in a
source repository (turning them into a waste of time for the patch submitter,
too). I thought I made that clear in our previous mail exchange <sigh>.

comment:2 Changed 13 years ago by fingolfin

Status: newpending

comment:3 Changed 13 years ago by SF/sf-robot

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

comment:4 Changed 13 years ago by SF/sf-robot

Status: pendingclosed

comment:5 Changed 13 years ago by SF/polluks

This patch adds a transparent version tag for AmigaOS, MorphOS and AROS,
something like CVS ident command. You can get the version without execution.

comment:6 Changed 13 years ago by SF/polluks

Status: closednew

comment:7 Changed 13 years ago by fingolfin

Still waiting for a *patch*, made against current SVN -- the version.cpp you attached is outdated.

Furthermore, it is not acceptable to modify gScummVMFullVersion like that, w/o having any comment explaining that odd code.

comment:8 Changed 13 years ago by fingolfin

Owner: set to fingolfin
Status: newpending

Changed 13 years ago by SF/polluks

Attachment: version.cpp.patch added

transparent Amiga version tag

comment:9 Changed 13 years ago by SF/polluks

This patch doesn't make anything fancy:
> version scummvm-original
Could not find version information for 'scummvm-original'
> version scummvm-patched
ScummVM 0.9

The pointer of gScummVMFullVersion needs an offset to ignore
the tag, gScummVMVersionDate just reuses the string, fine?

comment:10 Changed 13 years ago by SF/polluks

Status: pendingnew

comment:11 Changed 13 years ago by fingolfin

Status: newpending

comment:12 Changed 13 years ago by fingolfin

That patch applies against HEAD SVN, very good!

However, it still misses an explanatory comment. I.e. anybody looking at that code will be confused by the "$VER:" prefix. It's mandatory that a comment is added that explains *why* this prefix is added, else it'll be removed again during the next code audit.

comment:13 Changed 13 years ago by SF/sf-robot

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

comment:14 Changed 13 years ago by SF/sf-robot

Status: pendingclosed

comment:15 Changed 9 months ago by digitall

Component: Port: AmigaOS4
Note: See TracTickets for help on using tickets.