Opened 13 years ago

Closed 13 years ago

Last modified 11 months ago

#8554 closed patch

Bugfix [1498158] SIMON: Itemheap overflow on 64bit systems

Reported by: (none) Owned by: fingolfin
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Simon the Sorcerer 1

Description

The following patch fixes the above mentioned crash by
enlarging the item heap and fixing alignment for native
pointers. I simply doubled the heap size, but if memory
consumption is an issue on other architectures, I can
try to find a more precise lower bound.

Tested on AMD64 with Simon the Sorcerer 1 and 2.

Ticket imported from: #1522592. Ticket imported from: patches/659.

Attachments (1)

simon-crash-amd64-fix.diff (588 bytes ) - added by SF/*anonymous 13 years ago.
Patch file against Revision 23494

Download all attachments as: .zip

Change History (7)

by SF/*anonymous, 13 years ago

Attachment: simon-crash-amd64-fix.diff added

Patch file against Revision 23494

comment:1 by Kirben, 13 years ago

Owner: set to Kirben

comment:2 by Kirben, 13 years ago

Hopefully someone can test the patch with the Feeble Files
too, to check whether item heap is large enough now.

It would be helpful to know if the games are completable
now, if you are playing through them.

comment:3 by fingolfin, 13 years ago

Well, does this patch cause any regressions? If not, then why not apply it and
thus let more people test it? :-)

comment:4 by fingolfin, 13 years ago

Thanks, added to HEAD.

comment:5 by fingolfin, 13 years ago

Owner: changed from Kirben to fingolfin
Status: newclosed

comment:6 by digitall, 11 months ago

Component: Engine: AGOS
Game: Simon the Sorcerer 1
Note: See TracTickets for help on using tickets.