Opened 18 years ago

Closed 18 years ago

Last modified 6 years ago

#8541 closed patch (wontfix)

config file read_only keyword support

Reported by: SF/njoly Owned by: fingolfin
Priority: normal Component: --Other--
Version: Keywords:
Cc: Game:

Description

Hi,

The `read_only' keyword in the .scummvmrc configuration file does not seems to work yet, even if documented in the README file. Checking the code shows that this one is unimplemented yet.

The attached patch make it works, at least, for me.

Hope this helps, Regards.

Ticket imported from: #1500931. Ticket imported from: patches/646.

Attachments (1)

scummvm-readonly.diff (953 bytes ) - added by SF/njoly 18 years ago.
config file read_only keyword support

Download all attachments as: .zip

Change History (8)

by SF/njoly, 18 years ago

Attachment: scummvm-readonly.diff added

config file read_only keyword support

comment:1 by fingolfin, 18 years ago

Actually, that's the first time I hear about this config key. And I never noticed in the README before, so it appears new to me....

Oh yeah, ScummVM team communication never was that great *g*

comment:2 by eriktorbjorn, 18 years ago

It was something I suggested three years ago (see patch #750001) but it was rejected. I don't know how it ended up in the documentation, though. Maybe I accidentally used my patched version when I compiled the list, and no one read it until now... :-)

So it should probably just be removed from the documentation.

comment:3 by SF/njoly, 18 years ago

Thanks for the explanation.

I personnally like this feature a lot. I don't normally want processes to modify configuration files i wrote.

But i won't fight for this one. I' using sources from SVN, i can live with some local modifications ... Or even with a read-only' config file.

Feel free to close this one.

comment:4 by fingolfin, 18 years ago

How about simply setting the config file to be read only via your OS? At least on Windows, Linux, Mac OS X that is possible (although it might cause ScummVM to generate error message... hm... I never actually tried to do this :-).

comment:5 by SF/njoly, 18 years ago

I just checked, and i can confirm that `chmod 444 scummvmrc' works fine. The config file remains unchanged.

But it indeed generate one or more warning lines, depending of the previous tasks (temporary volume settings adjustements in games, ...).

Again, that's an acceptable solution. Feel free to close this report if you want.

comment:6 by fingolfin, 18 years ago

Owner: set to fingolfin
Resolution: wontfix
Status: newclosed

comment:7 by digitall, 6 years ago

Component: --Other--
Note: See TracTickets for help on using tickets.