Opened 17 years ago
Closed 16 years ago
Last modified 5 years ago
#8537 closed patch
residual: improve text object resource handling
|Reported by:||SF/mannythegnome||Owned by:||aquadran|
The attached patch ensures that the resources associated with a killed text object are destroyed (i.e. the bitmap) which prevents residual from becoming a resource hog in the main menu.
I'm not sure whether the delete statement is appropriate at that place, and I don't know enough CPP to judge whether the remove statement is superfluous, i.e. whether the delete statement implies removal from lists.
The patch also removes the TextObjectExists statement from BlastText(), which IMHO isn't neccessary (the object will be destroyed right after it was drawn).
Ticket imported from: #1495487. Ticket imported from: patches/642.
Change History (10)
by , 17 years ago
comment:1 by , 17 years ago
Hrm the actor.cpp code seem to call delete itself for each sayline deletion, while the deleteTextObjects code of the engine (that deletes all the text objects) does the deletion.
comment:2 by , 17 years ago
comment:3 by , 17 years ago
aquadran, do you think this patch can / should be applied?
comment:4 by , 17 years ago
i didn't have a time for look close into that patch yet. So i don't know yet.
comment:5 by , 17 years ago
Any news on this?
comment:6 by , 17 years ago
What is the status of this item?
comment:7 by , 17 years ago
stalled, i need look close into changes
comment:8 by , 16 years ago
|Status:||new → closed|
comment:9 by , 5 years ago