Opened 15 years ago

Closed 14 years ago

Last modified 23 months ago

#8508 closed patch

AmigaOS 4 changes

Reported by: SF/capehill Owned by: sev-
Priority: normal Component: Port: AmigaOS4
Keywords: Cc:
Game:

Description

This is a small patch which I should have sent months ago but forgot. This should make ScummVM CVS to compile again for AmigaOS 4.

Ticket imported from: #1416370. Ticket imported from: patches/613.

Attachments (2)

amigaos4_changes.diff (2.6 KB ) - added by SF/capehill 15 years ago.
amigaos4-fs fixes
diffs.txt (9.1 KB ) - added by SF/capehill 14 years ago.
Patch amigaos4-fs.cpp and tweak some other

Download all attachments as: .zip

Change History (11)

by SF/capehill, 15 years ago

Attachment: amigaos4_changes.diff added

amigaos4-fs fixes

comment:1 by sev-, 15 years ago

Owner: set to sev-
Status: newclosed

comment:2 by sev-, 15 years ago

Commited as is. Though I have a question. Are those debug() calls really problematic?

comment:3 by SF/capehill, 15 years ago

There was a problem when including "util.h" and I did overlook of solving that. I will fix that at some point. Solution seems to be trivial.

by SF/capehill, 14 years ago

Attachment: diffs.txt added

Patch amigaos4-fs.cpp and tweak some other

comment:4 by SF/capehill, 14 years ago

Status: closednew

comment:5 by SF/capehill, 14 years ago

This new patch should mainly fix the crash problem in fs/amigaos4-fs.cpp by adding the copy constructor back. Also games can be added again. Some coding convention improvements was done as well.

Currently there are some trouble with types and newlib compilation but I try to sort them out.

comment:6 by fingolfin, 14 years ago

I strongly reommend opening new tracker items for new patches, not reopening old items. In particular, I would never have noticed this reopening if capehill hadn't mailed me about it directly. Compare this to the fact that I get an email about every *new* tracker item :-).

Furthermore, while sev handled the old patch, somebody else might handle the new one, and we can't track that properly if you reopen the item.

You comment out the exec/types.h include, does that mean it can now be removed?

Sorry for removing the AmigaOSFilesystemNode copy constructor, I obviously overlooked the file lock duplication code :-(

Regarding debug(6, "Error\n"); there are two things wrong with that: 1) You don't need to add \n, this gets added automatically 2) This error message is kinda ... useless :-). How about changing it to "IDOS->IoErr() != ERROR_LINE_TOO_LONG" ?

comment:7 by SF/capehill, 14 years ago

Sorry about that :/ I will remember this next time.

Yeah, the project compiles without exec/types.h, so it could be removed.

Good points on debug(), I wonder what I was thinking..nothing?-) Anyway, I just reactivated the code as it was talked last time. Will improve error with the next iteration.

comment:8 by fingolfin, 14 years ago

Status: newclosed

comment:9 by digitall, 23 months ago

Component: Port: AmigaOS4
Note: See TracTickets for help on using tickets.