Opened 15 years ago

Closed 15 years ago

Last modified 2 years ago

#8463 closed patch

SAGA: Experimental cutaway fixes

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: SAGA
Keywords: Cc:
Game: I Have No Mouth

Description

This patch fixes two of the more noticeable issues with the IHNM intro: the frame rate issue, and a memory leak.

However, it does so by introducing a secondary animations list for the cutaway animations, and this is quite different from how the original did it.

On the other hand, it neatly solves the problem of retaining the old animation state, so that they can be restarted again after the animation has finished.

Anyway, it's still a bit messy and I don't want to apply it without some discussion.

Ticket imported from: #1304998. Ticket imported from: patches/568.

Attachments (1)

saga-cutaway.diff (5.7 KB ) - added by eriktorbjorn 15 years ago.
Patch against a September 26 CVS snapshot

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 15 years ago

Attachment: saga-cutaway.diff added

Patch against a September 26 CVS snapshot

comment:1 by eriktorbjorn, 15 years ago

Owner: set to sev-

comment:2 by sev-, 15 years ago

Actually it is good that this implementation doesn't follow original. Our goal is to implement behaviour, not the algorithms used, moreover origin is too DOS (i.e. single process) -centric.

Code looks ok, I don't understand why you say it's messy. Only thing which would be nice to have is some comments on what are you doing in the code and how. Otherwise I'd already commit it.

comment:3 by eriktorbjorn, 15 years ago

Owner: changed from sev- to eriktorbjorn
Status: newclosed

comment:4 by eriktorbjorn, 15 years ago

Perhaps "messy" is too strong a word, but it could use some cleanup at least. Anyway, I'll commit it. Thanks for looking!

comment:5 by digitall, 2 years ago

Component: Engine: SAGA
Game: I Have No Mouth
Note: See TracTickets for help on using tickets.