Opened 14 years ago

Closed 14 years ago

Last modified 13 months ago

#8441 closed patch

SMUSH threads & files

Reported by: fingolfin Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

This experimental patch tries to modify the SMUSH player
such that all file access is done from within a single
thread -- the SMUSH player thread/timer callback.

This should help systems where a file handle can only be
accessed from the thread it was created in (EPOC/Symbian).

This also should make it a bit easier to optimize file
access, see also bug #1174927.

Ticket imported from: #1227243. Ticket imported from: patches/546.

Attachments (1)

smush.patch (4.8 KB ) - added by fingolfin 14 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by eriktorbjorn, 14 years ago

I'll try it once you attach the file. ;-)

comment:2 by fingolfin, 14 years ago

Well, if you insist... although I think it would have been
far easier if you had just written an appropriate patch
based on the item description yourself, tsk tsk! :-)

by fingolfin, 14 years ago

Attachment: smush.patch added

comment:3 by eriktorbjorn, 14 years ago

Well, it still seems to be working like before, which is good.

It doesn't fix the Full Throttle slowdowns, but given your
description of the patch I didn't expect it to.

comment:4 by fingolfin, 14 years ago

Indeed; it's only transforming the code a bit, and moving
some file handling code to another thread. The only thing it
should affect is EPOC/Symbian; all other systems hopefully
work unchanged.

I'll commit this then (if it does cause subtle regressions,
we can still back it out again, right?).

comment:5 by fingolfin, 14 years ago

Owner: set to fingolfin
Status: newclosed

comment:6 by digitall, 13 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.