Opened 15 years ago

Closed 15 years ago

Last modified 2 years ago

#8429 closed patch

GOB: Possible 64-bit fix

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: Gob
Keywords: Cc:


wjp pointed out on #scummvm yesterday that Gobliiins casts between pointers and 32-bit integers quite a bit in parse.cpp. This patch is an attempt to do that pointer/integer conversion in what I hope is a safe way.

Of course, this is all very theoretical. I certainly don't have any 64-bit system to test it on.

I've played through the first few levels with this patch, and so far it seems to work.

Ticket imported from: #1195190. Ticket imported from: patches/534.

Attachments (1)

gob-pointers.diff (7.5 KB ) - added by eriktorbjorn 15 years ago.
Patch against a May 4 CVS snapshot

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 15 years ago

Attachment: gob-pointers.diff added

Patch against a May 4 CVS snapshot

comment:1 by eriktorbjorn, 15 years ago

Owner: set to sev-

comment:2 by fingolfin, 15 years ago

Patch looks good to me. The only potential problem would be if a place was missed in the conversion... but then it wouldn't be hard to clean that up when discovered. So I think this should be applied soon...

comment:3 by eriktorbjorn, 15 years ago

Status: newclosed

comment:4 by eriktorbjorn, 15 years ago

Ok, I've applied the patch (with one minor change -- I've added an assertion). I've played the game from start to the level with the big tree without noticing any problems.

comment:5 by eriktorbjorn, 15 years ago

Owner: changed from sev- to eriktorbjorn

comment:6 by digitall, 2 years ago

Component: Engine: Gob
Note: See TracTickets for help on using tickets.