Opened 15 years ago

Closed 13 years ago

Last modified 17 months ago

#8423 closed patch

GM/GS/MT-32 Init Patch

Reported by: SF/tbcarey Owned by: fingolfin
Priority: normal Component: Audio: MT32
Keywords: Cc:
Game:

Description

Patch to the earlier quicky patch. It should fix the following things:

1) Prevent FMTowns games from initializing as MT32 or GM or GS, which in turn prevents a crash caused by GS init calling midi->getPercussionChannel(), which YM2162 driver seems to be unable to handle (at least in this case).

2) Prevents null midi games from doing the same, when they shouldn't anyway.

3) Prevents MT-32 emulation (Munt) from doing GS init, which can mess up some of its percussion settings, etc.

The first two problems are caused because any non-Adlib sound driver that uses the imuse parser (as opposed to pc speaker, pcjr which don't) will return true for _midi_native. This shouldn't be the case, but it appears that _midi_native is only set up to be opposed to _adlib_native, so when if clauses are used to determine if an mt-32/gm specific portion of the code should run, YM2162 and NULL drivers still do so. This should prevent that, although the label '_midi_native' is still somewhat misleading.

Ticket imported from: #1186858. Ticket imported from: patches/528.

Attachments (1)

gsfix2.patch (1.7 KB ) - added by SF/tbcarey 15 years ago.

Download all attachments as: .zip

Change History (14)

by SF/tbcarey, 15 years ago

Attachment: gsfix2.patch added

comment:1 by kingguppy, 15 years ago

I'm currently working on that area of code, so I can't apply the patch directly. The stuff I'm working on cleans up this whole mess.

comment:2 by kingguppy, 15 years ago

Owner: set to kingguppy

comment:3 by fingolfin, 15 years ago

Status: newclosed

comment:4 by fingolfin, 15 years ago

What is the status of this item?

comment:5 by kingguppy, 15 years ago

I'll be able to finish the changes I mentioned within the next two weekends.

comment:6 by kingguppy, 15 years ago

Status: closednew

comment:7 by SF/tbcarey, 14 years ago

As far as I'm aware, this bug still exists. My earlier patch stopped FMTowns from initialising as GS (in a more kludgy fashion) but MT-32 emulation still allows GS initialisation, which is incorrect and will cause it so sound wrong.

comment:8 by sev-, 14 years ago

Jamieson, may you take a look into this? If not, please, unassign yourself.

comment:9 by sev-, 14 years ago

Owner: changed from kingguppy to SF/jamieson630

comment:10 by fingolfin, 14 years ago

Seems kingguppy is dead :-/

comment:11 by fingolfin, 13 years ago

Owner: changed from SF/jamieson630 to fingolfin
Status: newclosed

comment:12 by fingolfin, 13 years ago

I finally commited this -- it doesn't seem likely that kingguppy will return. If it breaks anything, this way at least we'll find out about it; if it doesn't, the much the better.

comment:13 by digitall, 17 months ago

Component: Audio: MT32
Note: See TracTickets for help on using tickets.