Opened 15 years ago

Closed 14 years ago

Last modified 13 months ago

#8412 closed patch

SKY: Buggy text and speech setting

Reported by: salty-horse Owned by: joostp
Priority: normal Component: Engine: Sky
Keywords: Cc:
Game: Beneath a Steel Sky

Description

The text and speech button in the control panel has
several problems this patch aims at fixing:
* Quitting the game in text-only mode reverts the
setting to text and speech when restarting the game.
The fix made use of the speech_mute key used in SCUMM
games.
* When entering the control panel for the first time,
the description of the current mode of the text and
speech setting doesn't appear.

There's a bit of code duplication with the setting's
conditional tree in control.cpp

Ticket imported from: #1171517. Ticket imported from: patches/517.

Attachments (1)

sky.patch (2.7 KB ) - added by salty-horse 15 years ago.
ok, now I got it

Download all attachments as: .zip

Change History (16)

comment:1 by joostp, 15 years ago

Thanks for the patch, however, there are some issues with it.

- The text that appears when you hover over the toggle
always reads "Text and Speech", surely that's not the intention.

- The text it shows in the 'status bar' doesn't match what
is depicted by the icons.

Hopefully you can address these issues and submit a new patch

comment:2 by salty-horse, 15 years ago

The hovering text mentions the purpose of the button.
I'll look into the status bar, which should display the
current value.

comment:3 by joostp, 15 years ago

I know it mentions the purpose of the button, but in this
case it ALWAYS mentions 'Text and Speech', not matter how
many times I click it.

comment:4 by fingolfin, 15 years ago

What is the status of this item?

comment:5 by salty-horse, 15 years ago

OK, here's an updated patch:
It now correctly saves/loads the text and speech setting and
also the fx mute setting.
I didn't change the status bar text/hover text - it's
currently not like the original behaviour, but IMO it was
unintuitive.

comment:6 by salty-horse, 15 years ago

OK, here's an updated patch:
It now correctly saves/loads the text and speech setting and
also the fx mute setting.
I didn't change the status bar text/hover text - it's
currently not like the original behaviour, but IMO it was
unintuitive.

comment:7 by joostp, 15 years ago

The current patch seems to have broken launching of the game.

Looking for sky
Trying to start game 'Beneath a Steel Sky'
Config file buggy: '' is not a valid bool!

by salty-horse, 15 years ago

Attachment: sky.patch added

ok, now I got it

comment:8 by sev-, 14 years ago

What is the status of this item?

comment:9 by salty-horse, 14 years ago

I uploaded a new version after joostp's comment. I checked
it against current cvs. Works fine to me.

comment:10 by joostp, 14 years ago

I wasn't aware there was a new patch.
Next time please add a comment as well.

Anyway, I'll take a look at it when I have some more time.

comment:11 by fingolfin, 14 years ago

Any news on this?

comment:12 by salty-horse, 14 years ago

Awaits review and check-in by a BASS developer.

comment:13 by joostp, 14 years ago

Owner: set to joostp
Status: newclosed

comment:14 by joostp, 14 years ago

I apologize for the fact that I completely forgot about this
patch until I was reminded again by the new comment.

This new patch (saving the sfx and speech toggles set in the
options menu) is perfectly fine and I've just committed it
to CVS.
Thanks!

comment:15 by digitall, 13 months ago

Component: Engine: Sky
Game: Beneath a Steel Sky
Note: See TracTickets for help on using tickets.