Opened 16 years ago

Closed 15 years ago

Last modified 23 months ago

#8408 closed patch

Shared GM/MT-32 mapping

Reported by: eriktorbjorn Owned by: kingguppy
Priority: normal Component: Audio: MT32
Keywords: Cc:
Game: Simon the Sorcerer 1

Description

Currently most of our game engines contain their own copy of the MT-32 to GM mapping. This patch moves the mapping, and the GM to MT-32 one, to the MidiDriver class. (Is that the right place for it?)

The idea here is that if we ever find an improved mapping we only need to change it in one place. And if an engine wants to provide a custom mapping, it'll be obvious that this is what it's doing. (E.g. the DOS version of Simon the Sorcerer 1 has a custom instruments file that could possibly provide hints for a better instrument mapping for this particular game.)

Ticket imported from: #1168149. Ticket imported from: patches/513.

Attachments (1)

midi-mapping.diff (18.3 KB ) - added by eriktorbjorn 16 years ago.
Patch against a March 21 CVS snapshot

Download all attachments as: .zip

Change History (11)

by eriktorbjorn, 16 years ago

Attachment: midi-mapping.diff added

Patch against a March 21 CVS snapshot

comment:1 by kingguppy, 16 years ago

Owner: set to kingguppy

comment:2 by fingolfin, 16 years ago

This sounds like a good idea to me. Reducing code duplication is always good.

comment:3 by SF/tbcarey, 16 years ago

This should be committed soon so that other structural changes can also take place, especially regarding GS support re: https://sourceforge.net/tracker/index.php?func=detail&aid=1164217&group_id=37116&atid=418822

Is there anything holding it up?

comment:4 by eriktorbjorn, 16 years ago

So what's the status of this? The main reason I didn't want to just commit it was that I wasn't sure if the MidiDriver class was the right place for the mappings. I don't have any further plans for the patch than what's already in it.

comment:5 by kingguppy, 16 years ago

I basically only get weekends to work on ScummVM, and last weekend was busy with Easter - that's the only reason for the delay. I'm not sure whether MidiDriver is the place for this either, and there are other MT-32 vs. GM issues that need to be addressed, so I plan to review all the code involved this weekend and see how it should best fit together.

comment:6 by eriktorbjorn, 16 years ago

Good enough for me. I just wasn't sure how to interpret your earlier comment, i.e. if you too were waiting for someone else to chime in on it. :-)

comment:7 by fingolfin, 16 years ago

If I might add in: if you don't get around to do a "proper" cleanup of the MT32/GM code, I'd recommend to just commit this patch for now. We can easily move the mappings to a better location later on, if we want -- as long as this patch doesn't add/remove files, everything in it is undoable :-)

comment:8 by kingguppy, 15 years ago

Status: newclosed

comment:9 by kingguppy, 15 years ago

Committed as-is. I didn't have time to do the related cleanup I'd intended.

comment:10 by digitall, 23 months ago

Component: Audio: MT32
Game: Simon the Sorcerer 1
Note: See TracTickets for help on using tickets.