Opened 16 years ago

Closed 16 years ago

Last modified 2 years ago

#8382 closed patch

BS2 without MPEG2 support msg

Reported by: SF/dataslayer Owned by: eriktorbjorn
Priority: normal Component: Engine: Sword2
Keywords: Cc:
Game: Broken Sword 2

Description

This patch implements Feature Request 1088761, adding different messages for missing videos or lacking support of MPEG2 in BS2.

I checked that both messages fit into the menu area (see comment @ sword2/driver/animation.cpp:353).

Maybe this should be applied to 0.7.0, because it can be rather confusing to figure out what's wrong if you're missing MPEG2 support. (as stated in my original feature request)

Ticket imported from: #1088948. Ticket imported from: patches/487.

Attachments (1)

bs2_no_mpeg2.diff (933 bytes ) - added by SF/dataslayer 16 years ago.
Patch against 0.7.0 branch

Download all attachments as: .zip

Change History (10)

by SF/dataslayer, 16 years ago

Attachment: bs2_no_mpeg2.diff added

Patch against 0.7.0 branch

comment:1 by sev-, 16 years ago

Patch does not apply cleanly as there recently were changes, but since it is trivial, there is no way to redo it :).

I didn't do it by myyself as I am not sure which messages it should produce and how.

comment:2 by SF/dataslayer, 16 years ago

> Patch does not apply cleanly as there recently were changes [...]

Strange, I thought I made sure it was against the latest cvs (0.7.0 branch).

Oh there were changes in HEAD, I see. Well, either apply the patch to 0.7.0, or as sev said rework the changes...

comment:3 by fingolfin, 16 years ago

Applying a patch against the 0.7.0 release branch makes no sense, unless we wanted to have it appear in a potential 0.7.1 release; however, before any feature change can be considered for that, it must first be applide to HEAD.

Hence we need a patch which applies against HEAD :-). Thanks.

comment:4 by fingolfin, 16 years ago

Owner: set to eriktorbjorn

comment:5 by fingolfin, 16 years ago

Erik, wanna take a look at this and see if you can somehow get it into CVS? (Assuming you judge it OK to do so)

comment:6 by eriktorbjorn, 16 years ago

Well, I could fix the English message - it's only a cosmetic fix, after all - but sev added a Russian translation of that message recently, and I wouldn't dare to touch that.

Which languages were the game translated to anyway? Based on initialiseFontResourceFlags(), there appears to have been at least English, German, Finnish and Polish version as well. (And American, if you want to count that as a translation.)

comment:7 by eriktorbjorn, 16 years ago

Status: newclosed

comment:8 by eriktorbjorn, 16 years ago

I've made the minor change of keeping the two versions of the message separate, rather than using string concatenation. (I just think it's a bit easier to read that way.)

Other than that, I've applied it both to the trunk and the 0.7.x branch.

comment:9 by digitall, 2 years ago

Component: Engine: Sword2
Game: Broken Sword 2
Note: See TracTickets for help on using tickets.