Opened 16 years ago

Closed 16 years ago

Last modified 8 months ago

#8185 closed patch

Fix for graphics glitches after saving

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 1


This patch should prevent graphics glitches when saving
a game, manually or by autosave. Because the "usage
bits" array was made larger recently, I added code to
automatically clear it before loading a game so that
there wouldn't be any garbage in it when loading an
older savegame.

At least that was the intention. What it actually does
it to clear the array both before loading *and* saving.
What the hell was I thinking?!

One particularly noticeable example of this bug happens
if you save while talking to the Voodoo Lady in CMI.

By the way, I'm not sure clearing the array is
necessary even in the load case. In fact, I'm not
entirely convinced that we have to save the usage bits
at all. The full redraw after loading a savegame just
might be enough to reconstruct them. But I don't know.

Ticket imported from: #697846. Ticket imported from: patches/290.

Attachments (1)

usage_bits.diff (618 bytes) - added by eriktorbjorn 16 years ago.
Patch against a March 4 CVS snapshot

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by eriktorbjorn

Attachment: usage_bits.diff added

Patch against a March 4 CVS snapshot

comment:1 Changed 16 years ago by fingolfin

Owner: set to fingolfin
Status: newclosed

comment:2 Changed 16 years ago by fingolfin

Seems fine.

comment:3 Changed 8 months ago by digitall

Component: Engine: SCUMM
Game: Monkey Island 1
Note: See TracTickets for help on using tickets.