Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8141 closed patch

DOTT: Fix for some animation glitches

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Day of the Tentacle

Description

This patch fixes the animation timing glitches in the DotT epilogue described in bug #555319 ("DOTT: Epilogue Problem"). This, I expected. What I didn't expect was that it also seems to fix bug #558310 ("DOTT: Flickering Chron-O-John"), and I haven't really checked why or how.

It also fixes at least one other, less noticeable animation glitch where the Chron-O-John Bernard, Hoagie and Laverne uses near the end of the game is falling too slowly. And since the patch isn't DotT-specific, it might affect other games as well.

Of course, it might also *break* things, but I haven't seen that happen. Yet. :-)

What the patch does is simply to make initActor() reset animSpeed to 1 (0 would work just as well). Since it already resets walk speed, this seems like a reasonable thing to do.

I have absolutely no idea where DotT - or any other game - changes the animation speed of an actor. It can't be used very much, or we should have seen this problem happening a lot more often. But at least now I know why I have one savegame where I can reproduce the "Flickering Chron-O-John" bug and one where I can't. If you use the super-battery early enough, apparently it won't happen.

Ticket imported from: #649358. Ticket imported from: patches/246.

Attachments (3)

dott-anim.diff (390 bytes ) - added by eriktorbjorn 18 years ago.
Patch against a December 5 CVS snapshot
tentacle.s21 (52.3 KB ) - added by eriktorbjorn 18 years ago.
Savegame near flickering Chron-O-John
tentacle.s32 (36.1 KB ) - added by eriktorbjorn 18 years ago.
Savegame near Epilogue

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 18 years ago

Attachment: dott-anim.diff added

Patch against a December 5 CVS snapshot

by eriktorbjorn, 18 years ago

Attachment: tentacle.s21 added

Savegame near flickering Chron-O-John

by eriktorbjorn, 18 years ago

Attachment: tentacle.s32 added

Savegame near Epilogue

comment:1 by SF/ender, 18 years ago

Owner: set to SF/ender
Status: newclosed

comment:2 by SF/ender, 18 years ago

Applied to both 0.3.0 and current CVS HEAD.

(There's no way this should break anything, it looks like it was just a stupid oversight when writing initActor :)

comment:3 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Day of the Tentacle
Note: See TracTickets for help on using tickets.