#8130 closed patch
SAM: Fix for graphics glitch
| Reported by: | eriktorbjorn | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Sam and Max |
Description
This patch fixes a graphics glitch at the Ball of Twine:
* Walk Sam to the foot of the stairs to the gondola platform.
* Wait until Max stops walking. He should now be standing in the parking lot.
* Walk Sam up the stairs. As the camera moves to the right, you should see a partially drawn Max appear on the right side of the screen.
This happens because Max is drawn with _xpos < 0, so he "wraps around" to the right side.
It's possible/probable that it fixes other similar bugs - I've made the change in all the codecs, not just the one that causes the Sam & Max glitch - but this is the only one I know how to trigger in any reliable way.
An alternative fix would probably be to make _xpos unsigned. I'm not suggesting we actually do it this way since it's not human-readable, but it could explain why the code was reverse-engineered to only clip against the right edge of the screen.
Oh, and the same thing probably applies to AKOS as well, but I don't know of any test cases for it.
Ticket imported from: #639699. Ticket imported from: patches/235.
Attachments (2)
Change History (6)
by , 22 years ago
| Attachment: | costume-clipping.diff added |
|---|
comment:1 by , 22 years ago
I should point out that I've done little or no regression testing, but it seems like an obviously correct fix to me. (A sure sign that I've missed something. ;-)
comment:3 by , 22 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:4 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Sam and Max |
Patch against a November 16 CVS snapshot