Opened 17 years ago

Closed 17 years ago

Last modified 17 months ago

#8128 closed patch

FT: Experimental fuel tower fix

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Full Throttle

Description

This has not been regression-tested at all, so don't apply it until it has been further investigated.

It's an attempt at fixing the fuel tower animation glitch when the hover-whatever goes in for landing.

It seems that what causes the nasty jump in the animation is a call to adjustActorPos() from showActor(). This patch removes the call to adjustActorPos() for GF_AFTER_V7 games, but there are several other possible way to work around the bug. I have no idea if I picked the right one.

Ticket imported from: #638253. Ticket imported from: patches/233.

Attachments (1)

ft-hack.diff (482 bytes ) - added by eriktorbjorn 17 years ago.
Patch against a November 13 CVS snapshot

Download all attachments as: .zip

Change History (8)

by eriktorbjorn, 17 years ago

Attachment: ft-hack.diff added

Patch against a November 13 CVS snapshot

comment:1 by SF/ender, 17 years ago

Owner: set to SF/ender
Status: newclosed

comment:2 by SF/ender, 17 years ago

Applied - we'll need to re-regression test The Dig after a new more pending patches are applied anyway. And my basic regression testing seems fine with this patch, so we'll see what happens.

comment:3 by eriktorbjorn, 17 years ago

Unfortunately it seems to break a lot in The Dig, and probably Fuel Throttle as well, so we're going to have to revert this and make a better fix.

I still don't know how to handle it correctly, but it may be worth noting that it's setActorCostume( ) that causes the call to hideActor( ) and showActor( ).

comment:4 by eriktorbjorn, 17 years ago

I'm guessing this is what caused bug #639675. That'll teach me to do at least basic regression testing before submitting anything completely experimental...

comment:5 by SF/ender, 17 years ago

Reverted.

What Dig bugs did it cause? Are any of them actually in the bug system? (eg, what bugs can i close after reverting, if any :)

comment:6 by eriktorbjorn, 17 years ago

I don't think any Dig bugs related to this made it into the tracker.

Apparently the adjustActorPos() is used to put the actor in the correct box when entering the room, so the problems it caused were masking problems, walkbox problems, and and potential out-of-range crashes when entering a room with fewer boxes than the one you were previously in.

As I said, I should have tested it a bit more before I submitted it. :-)

I still don't know how to fix the bug properly. As a last resort, I guess we could make a game-specific hack...

comment:7 by digitall, 17 months ago

Component: Engine: SCUMM
Game: Full Throttle
Note: See TracTickets for help on using tickets.