Regression fix: Simon crashes on start
|Reported by:||eriktorbjorn||Owned by:||fingolfin|
|Game:||Simon the Sorcerer 1|
At least under UNIX the Simon games crashes on start-up
because GameDetector::createMidi() returns NULL.
I don't know enough about Simon to fix it properly
(e.g. by adding a MIDI -> AdLib converter or
implementing streaming - whatever that is - for the
MIDI drivers that don't have it), so what I do instead
is to return MidiDriver_NULL_create(), if it's a Simon
game and it would have otherwise returned NULL.
The patch also changes error() slightly so that the
Simon games can use it without crashing. The problem
here was that g_scumm was NULL, so it couldn't call
g_scumm->_system->quit(). I've changed it to use
g_system->quit() instead, even though g_system is
labelled as a "BIG HACK"
Ticket imported from: #620625. Ticket imported from: patches/189.