Opened 22 years ago

Closed 22 years ago

Last modified 6 years ago

#8055 closed patch

Further drawBomp() cleanups

Reported by: eriktorbjorn Owned by: aquadran
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game:


This patch further cleans up the new drawBomp() implementation. It removes one theoretical - but extremely unlikely - memory leak, slightly optimizes the image scaling, and removes the floating-point math from the blending function.

There are still some FIXMEs, and some places in the code - e.g. drawBlastObject() - which assume that drawBomp() can't scale images, but this shouldn't cause any visible harm.

Ticket imported from: #610954. Ticket imported from: patches/160.

Attachments (1)

drawbomp2.diff (3.7 KB ) - added by eriktorbjorn 22 years ago.
Patch against a September 17 CVS snapshot

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 22 years ago

Attachment: drawbomp2.diff added

Patch against a September 17 CVS snapshot

comment:1 by aquadran, 22 years ago

Status: newclosed

comment:2 by fingolfin, 22 years ago

If you accept a patch, please make sure to assign the tracker item to you, to clearly flag you as the person who reviewed & accepted the patch, and thus also is responsible for any regressions caused by it.

OK in this case aquadran was not setup as a tracker technican, so he couldn't have assigned this to himself :-)

comment:3 by fingolfin, 22 years ago

Owner: set to aquadran

comment:4 by digitall, 6 years ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.