Opened 18 years ago

Closed 18 years ago

Last modified 21 months ago

#8022 closed patch (wontfix)

Loom flashlight hack

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

I was very happy to see that flashlight support has been added to ScummVM. Unfortunately it's broken in Loom CD.

o5_lights() is called twice: supposedly once to turn on the flashlight, and once to set its dimensions. However, the b and c variables are set to 0 in both cases, so it just turns on the flashlight twice and then doesn't do anything useful with it.

I have no idea to solve this properly, so this patch is just a quick workaround hack.

Ticket imported from: #598621. Ticket imported from: patches/127.

Attachments (1)

loomlight.diff (911 bytes ) - added by eriktorbjorn 18 years ago.
Patch against an August 21 CVS snapshot

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 18 years ago

Attachment: loomlight.diff added

Patch against an August 21 CVS snapshot

comment:1 by fingolfin, 18 years ago

The proper fix is to simply initialize the flashlight size variables to 7 and 7 - that's apparently how the original does it, too.

comment:2 by fingolfin, 18 years ago

Owner: set to fingolfin
Resolution: wontfix
Status: newclosed

comment:3 by digitall, 21 months ago

Component: Engine: SCUMM
Game: Loom
Note: See TracTickets for help on using tickets.