Opened 22 years ago

Closed 22 years ago

Last modified 5 years ago

#7995 closed patch

Getting simon2win to start at all

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: AGOS
Version: Keywords:
Cc: Game: Simon the Sorcerer 2


When I try to start simon2win, ScummVM complains that it can't read effects offsets. Since Simon 2 doesn't have an effects file (apparently voices and effects are stored together in one single file), it shouldn't even be trying.

That it does is because fopen_maybe_lowercase() takes the empty string, prepends _game_path and appends "." to it, i.e. it's trying to open the game directory as a file.

This patch will cause fopen_maybe_lowercase() to return NULL if you try to open NULL or an empty string.

It's still not playable because it will hang pretty early on, but it's still an improvement. :-)

The patch is made against a July 31 CVS snapshot.

Ticket imported from: #589718. Ticket imported from: patches/100.

Attachments (1)

simon2.diff (501 bytes ) - added by eriktorbjorn 22 years ago.
Trivial patch

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 22 years ago

Attachment: simon2.diff added

Trivial patch

comment:1 by SF/ender, 22 years ago

Applied, thanks.

comment:2 by SF/ender, 22 years ago

Owner: set to SF/ender
Status: newclosed

comment:3 by digitall, 5 years ago

Component: Engine: AGOS
Game: Simon the Sorcerer 2
Note: See TracTickets for help on using tickets.