Opened 17 years ago

Closed 17 years ago

Last modified 8 months ago

#7961 closed patch

Sound crash

Reported by: SF/mkarcher Owned by: SF/ender
Priority: normal Component: Audio
Keywords: Cc:


The calculation of the effective sample length in
mixer.cpp for raw streams is wrong. You divide rate and
length by two unless the length is less than 65536.
Mathematically this is OK, but if length is divisible
by 4, and rate is not divisible by four the quotient
gets larger by this operation, so you get a too long
effective sample length.

Ticket imported from: #550951. Ticket imported from: patches/66.

Attachments (1)

scummdiv (596 bytes) - added by SF/mkarcher 17 years ago.
patch fixing sound crash

Download all attachments as: .zip

Change History (4)

Changed 17 years ago by SF/mkarcher

Attachment: scummdiv added

patch fixing sound crash

comment:1 Changed 17 years ago by SF/ender

Thanks a lot for tracking this one down! This finally gets
rid of those annoying german language crashes ;)

It was such a deeply burried bug I never found it before.

comment:2 Changed 17 years ago by SF/ender

Owner: set to SF/ender
Status: newclosed

comment:3 Changed 8 months ago by digitall

Component: Audio
Note: See TracTickets for help on using tickets.