Opened 12 years ago

Closed 8 years ago

Last modified 7 months ago

#7566 closed enhancement (fixed)

WIN: don't display hidden/system folders

Reported by: SF/clemty Owned by: Kirben
Priority: normal Component: Port: Win32
Keywords: Cc:
Game:

Description

as raised in http://forums.scummvm.org/viewtopic.php?t=3889 - the linux version of ScummVM doesn't display folders starting with "." (convention for hiding files on *nix) - analogous, on windows folders like the trash bin (\recycler) and other system folders probably shouldn't be shown

hardcoding those folders is a bad idea, but I think it should be possible to just not list any folders with the file attributes "s" (system) or "h" (hidden)

C:\>attrib C:\recycler
SH C:\RECYCLER

C:\>

Ticket imported from: #1726611. Ticket imported from: feature-requests/382.

Change History (7)

comment:1 Changed 12 years ago by SF/mthreepwood

Though I don't have much say in the matter, I would be against hiding hidden folders/files. It doesn't really harm anything.

And, the system ones should be listed because older versions of Windows still use the Windows folder for the config file.

But

comment:2 Changed 12 years ago by fingolfin

Owner: set to Kirben
Summary: launcher/windows: don't display hidden/system foldersWIN: don't display hidden/system folders

comment:3 Changed 12 years ago by fingolfin

Kirben, any oppinion on this?

comment:4 Changed 8 years ago by Templier

Implemented in 2d2ee68 by honoring the hidden parameter to the AbstractFSNode::getChildren() function

Hidden folders (such as the Recycle bin) are no longer visible in the file browser (as was already the case for the Posix and related backends). This is particularly visible on system disks where the majority of the listed folders were hidden, system-related and not user-writable (Boot, Recovery, System Volume Info, MSOCache, Recycle Bin, Config.Msi, Recycler, etc.)

comment:5 Changed 8 years ago by Strangerke

Fixed in master by littleboy

comment:6 Changed 8 years ago by Strangerke

Resolution: fixed
Status: newclosed

comment:7 Changed 7 months ago by digitall

Component: Port: Win32
Note: See TracTickets for help on using tickets.