Opened 15 years ago

Closed 5 years ago

Last modified 9 months ago

#7402 closed enhancement

DEBUGGER: Add parameter validation

Reported by: SF/clemty Owned by:
Priority: low Component: GUI
Keywords: Cc:
Game: Flight of the Amazon Queen


ScummVM 0.7.0 win32

debugger quirk:

FOTAQ example:
command 'song' expects a number as parameter, if you
enter sth like 'a' or 'aa' as parameter song 0 is selected

BASS example:
'section' expects a number between 0 and 6 (source
contains check to give error on any number outside this
range) - if you enter 'a' as parameter it treats it like
'section 0'

Ticket imported from: #1096009. Ticket imported from: feature-requests/218.

Change History (9)

comment:1 Changed 15 years ago by fingolfin

I'd not consider this a bug, rather a feature request for type
checking... Those debuggers are really mostly meant for
us developers as a tool to aid us in debugging stuff... they
are not meant to be user friendly, and so we only spend
enough effort in that regard as is helpful for our own work.

comment:2 Changed 15 years ago by fingolfin

Component: --Unset--
Summary: Debugger: doesn't check wether param is nr or charDEBUGGER: Add parameter validation

comment:3 Changed 15 years ago by SF/clemty

heh, okie
just thought I mention it, expected it to get a priority of like 1
anyway :-)

hey, but whoever did the debugger added this uberleet sliding
effect when entering it - I wonder how helpful that is to your
work, hehe (I love it, sitting here turning the debugger off and
on all day)


comment:4 Changed 15 years ago by fingolfin

I spent the effort to write that slide effect, and it serves
absolutely no purpose, I just wanted to show how simple
it is to implement the effect ;-)

comment:5 Changed 15 years ago by sev-

Well, Max implemented this by my request. I liked it a lot
as part of SAGA engine, and since I use debugger quite
often, why not add some bells and whistles to it?

Lam... err... User-bait is a side effect, though :).

comment:6 Changed 15 years ago by SF/clemty

Priority: normallow

comment:7 Changed 5 years ago by digitall

Have added code as commits a48e54c4595329afabd3247a1a9ac560ae258f05 and d356f1716110ab374e394bf1fa80be0edf94b9b7 to fix the issues reported by the original submitter. This should act as good templates for other engine authors to fix / improve this if desired.

However, as adding parameter validation is a issue for each engine author and this is an ongoing task with no defined enpoint, I am going to close this Feature Request here as closed-later.

Maybe in future, some further "cooked in" validation function will be added to a debug console superclass, but for now, this will be done on a case-by-case basis.

comment:8 Changed 5 years ago by digitall

Status: newclosed

comment:9 Changed 9 months ago by digitall

Component: GUI
Game: Flight of the Amazon Queen
Note: See TracTickets for help on using tickets.