Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6739 closed defect (fixed)

SCUMM: Strings from resources are not translated

Reported by: BenCastricum Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Freddi Fish 1

Description

Some strings from the string_map_table in dialogs.cpp are marked for translation, but (at least some of them) are never translated runtime. The screenshot shows one example. I debugged this specific case a little and noticed that the string show on screen also is not read from the table in dialogs.cpp but probably from a file from the game. Because the string that was read was

  • Are you sure you want to quit? (Y/N)Y

and the table does not contain that one. If we want to translate in-game strings than there is still some work to do. If not, then we can remove those _s() calls from the table I guess. The relevant code for this is engines/scumm/dialogs.cpp:424

Freddi Fish 1 is a v6 game (that helps reading the source)

Ticket imported from: bugs/6739.

Attachments (1)

freddi-quit.png (285.3 KB ) - added by BenCastricum 9 years ago.

Download all attachments as: .zip

Change History (4)

by BenCastricum, 9 years ago

Attachment: freddi-quit.png added

comment:1 by digitall, 9 years ago

Ben has submitted a fix for this as a Pull Request here: https://github.com/scummvm/scummvm/pull/523

Once this fix gets merged, this bug can be closed as fixed.

comment:2 by bluegr, 9 years ago

Component: Engine: SCUMM
Game: Freddi Fish 1
Owner: set to Kirben
Resolution: fixed
Status: newclosed

comment:3 by bluegr, 9 years ago

Many thanks for your work, Ben!

The fix for this has now been merged, after talking with Kirben.

Closing this, and assigning it to Kirben.

Note: See TracTickets for help on using tickets.