Opened 10 years ago

Closed 15 months ago

Last modified 15 months ago

#6710 closed defect (fixed)

SCUMM/HE: PUTT-PUTT - Colour corruption upon pressing Escape too quickly

Reported by: SF/saleck86 Owned by: AndywinXp
Priority: low Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Putt-Putt Joins the Parade

Description

Hello ScummVM Dev Team.

This bug occurs in ScummVM 1.7.0. This colour corruption bug occurs if the user pressses Escape to skip the cutscene just before the sun begins to rise or is rising in the opening sequence. The bug goes away when Putt-Putt leaves his house.

Ticket imported from: bugs/6710.

Attachments (3)

scummvm 2014-08-19 02-23-11-28.png (67.1 KB ) - added by SF/saleck86 10 years ago.
Putt-Putt 1_ Joins the Parade _000.png (34.9 KB ) - added by raziel- 4 years ago.
ScummVM 2.2.0git screenshot
Pressing Escape During Sunrise.gif (1.8 MB ) - added by Thunderforge 2 years ago.

Download all attachments as: .zip

Change History (13)

by SF/saleck86, 10 years ago

comment:1 by digitall, 10 years ago

Summary: Colour corruption upon pressing Escape too quicklySCUMM: PUTT-PUTT - Colour corruption upon pressing Escape too quickly

comment:2 by digitall, 10 years ago

saleck86: Please answer the following questions: 1. What Operating System are you using? 2. Did this occur in previous versions? If not, please locate the last version which does not exhibit this bug. 3. Did this occur in the original interpreter? Please try with the original interpreter under Win32...

comment:3 by SF/saleck86, 10 years ago

1) I am using Windows 7 64bit and Linux Mint 17 KDE 64bit edition. 2) Testing on Linux Mint, the problem happens as far back as ScummVM 1.0.0. I cannot test any versions lower than that because of really old and obsolete dependencies. The picture that was taken for demonstration was taken on Windows 7 though. 3) I'll get back to you on that once I find the hard copy. It never really worked well to begin with so I just used ScummVM to emulate it instead.

comment:4 by SF/saleck86, 10 years ago

OK I found the CD and gave it a try and the bug does not appear on this version. Upon pressing escape, the screen goes black for a moment and then loads Putt-Putt in the garage. All looks correct.

So it is definitely a ScummVM problem sadly.

by raziel-, 4 years ago

ScummVM 2.2.0git screenshot

comment:5 by raziel-, 4 years ago

ScummVM 2.2.0git (Jul 15 2020 10:24:49)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC A/52 FreeType2 FriBiDi JPEG PNG cloud (servers, local)

I can confirm this issue with above version of ScummVM.

After the intro screen where Put-Putt introduces himself, the scene with the sun coming up is drawn.
Immediately press ESC and the following scene in the garage is drawn, with completely messed up colours.

Attached another screenshot.

Putt-Putt 1: Joins the Parade (Windows/English)

AmigaOS4 - PPC - BE - SDL

comment:6 by sev-, 2 years ago

Summary: SCUMM: PUTT-PUTT - Colour corruption upon pressing Escape too quicklySCUMM/HE: PUTT-PUTT - Colour corruption upon pressing Escape too quickly

comment:7 by Thunderforge, 2 years ago

Issue #13573 was a duplicate of this bug.

Version 0, edited 2 years ago by Thunderforge (next)

by Thunderforge, 2 years ago

comment:8 by AndywinXp, 15 months ago

Owner: set to AndywinXp
Resolution: fixed
Status: newclosed

Fixed in master!

in reply to:  8 ; comment:9 by Thunderforge, 15 months ago

Replying to AndywinXp:

Fixed in master!

Thanks for the commit. Can you please also add a comment in the code explaining what the bug fix is accomplishing and why? The Sam & Max fix below yours does a great job of this.

in reply to:  9 comment:10 by AndywinXp, 15 months ago

Replying to Thunderforge:

Replying to AndywinXp:

Fixed in master!

Thanks for the commit. Can you please also add a comment in the code explaining what the bug fix is accomplishing and why? The Sam & Max fix below yours does a great job of this.

The difference is that this is an actual code path from the original disassembly, while the SAMNMAX one is a workaround which IMHO needs an explaination more than my changes; this is why I felt it didn't need any big comment.

Note: See TracTickets for help on using tickets.