Opened 6 years ago

Closed 5 years ago

#6483 closed defect (fixed)

SCI: LB2 - Music glitches in Olympia's & Yvette's offices

Reported by: SF/boneosaurusrex Owned by: wjp
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Laura Bow 2: The Dagger of Amon-Ra

Description

I was testing the recent changes to the SCI music code and it's working really well. I've just found one (two?) minor issues that have been introduced.

When entering certain rooms the music often doesn't start immediately, causing the beginning of the music track to be skipped. In addition, when leaving some of these rooms the track gets stuck on a note for a while (sometimes over a minute) before stopping. Depending on the note this can be a grating, unpleasant sound. This behavior didn't occur before the recent changes that fixed overlapping music.

The rooms I'm seeing this in are Olympia's and Yvette's offices, though I can't be sure there aren't more.

I've included a save game from the very start of Act III. Neither Olympia's or Yvette's offices have been visited yet. This game was started from the beginning using the latest ScummVM code (January 7th), so its state wasn't affected by the earlier music handling code.

To reproduce:

  1. Load save game
  2. Walk to the hall outside Olympia's office
  3. Enter Olympia's office; it will take ~2 seconds for the music to start and the opening ~2 seconds will have been skipped.
  4. Exit Olympia's office back to the hall; a note from Olympia's track will be stuck playing. Depending on the note it may be easy to hear or very quiet.
  5. Enter the hall to the upper right; the stuck note will continue to play in the next room.

This affects both floppy and CD versions. The attached save game is from the CD version. Tested with ScummVM Win32 latest.

Thanks for all your hard work!

Ticket imported from: bugs/6483.

Attachments (1)

laurabow2-cd.000 (46.1 KB ) - added by SF/boneosaurusrex 6 years ago.

Download all attachments as: .zip

Change History (7)

by SF/boneosaurusrex, 6 years ago

Attachment: laurabow2-cd.000 added

comment:1 by wjp, 6 years ago

Which midi driver are you using?

comment:2 by SF/boneosaurusrex, 6 years ago

I haven't ever explicitly set any audio settings in ScummVM so I may not understand the question, but I'd assume the answer is whatever the defaults are.

At the global level under the MIDI tab, GM Device is set to "Don't use General MIDI music". Mixed Adlib/MIDI mode is unchecked. SoundFont is None. Under the MT-32 tab "Don't use Roland MT-32 music" is set and both checkboxes are unchecked. Under Audio all dropdowns are set to default.

At the game level there are no overriding settings under the MIDI or MT-32 tabs. The Audio tab has everything set to default.

At the Windows level, the name of the MIDI music playback default device is "Microsoft GS Wavetable SW Synth".

comment:3 by wjp, 5 years ago

I think I have just fixed the bug that caused the first few seconds of these songs to be missing after a cross-fade.

However, I can't seem to reproduce the stuck note.

comment:4 by SF/boneosaurusrex, 5 years ago

I just confirmed that that fixed the missing music bug.

I can no longer reproduce the stuck note issue. I tried the recent nightly build and also the early January build that I had originally witnessed it in. I used the same save game, same machine, so it feels like whatever caused that was on my end and has passed.

Thank you!

comment:5 by wjp, 5 years ago

Thanks for testing.

comment:6 by wjp, 5 years ago

Component: Engine: SCI
Game: Laura Bow 2: The Dagger of Amon-Ra
Owner: set to wjp
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.