Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6460 closed defect (fixed)

SCI: LB2 - Bugs with Safe in Carrington's Office

Reported by: SF/boneosaurusrex Owned by: m-kiewitz
Priority: normal Component: Engine: SCI
Keywords: original Cc:
Game: Laura Bow 2: The Dagger of Amon-Ra

Description

I'm seeing two issues with the safe in Carrington's office that only occur in ScummVM and not Sierra SCI. I'm reporting them as one bug because they appear intertwined and I think it would be confusing to try to express this across two different reports. (My apologies if this turns out to be more confusing!) This may be related to a script patch in ScummVM that's supposed to fix something about the safe's behavior.

The first issue only occurs in the floppy version under ScummVM. When Wolf enters Carrington's office to kick you out upon your third attempt at opening the safe after two unsuccessful ones, you become stuck in Carrington's office forever and can't complete the game. Laura is supposed to walk through the open door (opened from Wolf's entrance) and transition to Yvette's office, but instead under ScummVM Laura walks to the lower left corner of the screen and stops. This leaves you still in Carrington's office. You can now walk around and even interact with Wolf by asking him questions, etc, but you can't leave the room. Clicking the hand icon on the door now closes it (!) and clicking it again opens it, but nothing you do allows you to leave. Walking into the void of the open door doesn't triggers a room transition. (Normally you exit the room by opening the door with the hand icon, then automatically walking out the door.) And now that we're in an undefined state, we can have fun by trying more incorrect safe combinations until we re-summon Wolf, causing the already open door to re-open and Wolf to disappear and re-enter the room. Seriously, this is how I have fun. Again, this is the floppy version only, you are successfully kicked out of the room with the CD version under ScummVM.

The second issue is a behavior difference between Sierra SCI and ScummVM that occurs in both floppy and CD versions. When you walk away from the safe in Sierra SCI the safe closes (if open) and the picture closes. "Walking away" in this case can be due to anything such as clicking the walk icon or hand icon somewhere else. In ScummVM the safe and picture stay open, but are returned to their closed state when re-entering the room.

Here's why I think these are intertwined. There is one exception to Sierra SCI's "always close safe/picture when walking away" rule: when Wolf kicks you out. In that case the picture remains open (the safe being already closed) while you leave the room. But when ScummVM runs the floppy version and Wolf kicks you out, the picture does automatically close, which is the same scenario when you get stuck. ScummVM running the CD version has the picture remaining open like Sierra SCI.

In review:

Sierra SCI Floppy & CD:
Safe/Picture closes when walking away, stays open when Wolf boots you.
ScummVM Floppy:
Safe/Picture stays open when walking away, closes when Wolf boots you (then traps you)
ScummVM CD:
Safe/Picture stays open when walking away, stays open when Wolf boots you.

Attached are screenshots of ScummVM/floppy where Laura is stuck in the room after failing to leave and the picture having auto-closed. Savegames are attached right after entering Carrington's office (before trying the safe) for ScummVM floppy and CD versions and Sierra SCI floppy and CD versions.

Combo for safe is 0527.

ScummVM 1.7.0 nightly
Laura Bow 2 1.0 Floppy English & 1.1 CD English

Ticket imported from: bugs/6460.

Attachments (6)

laurabow2.005 (44.8 KB ) - added by SF/boneosaurusrex 6 years ago.
laurabow2-cd.011 (50.9 KB ) - added by SF/boneosaurusrex 6 years ago.
SierraSCI CD - LB2SG.004 (12.0 KB ) - added by SF/boneosaurusrex 6 years ago.
SierraSCI Floppy - LB2SG.016 (21.0 KB ) - added by SF/boneosaurusrex 6 years ago.
hangin_with_mr_heimlich_(floppy).png (31.3 KB ) - added by SF/boneosaurusrex 6 years ago.
laura_stopping_instead_of_leaving_(floppy).png (36.3 KB ) - added by SF/boneosaurusrex 6 years ago.

Download all attachments as: .zip

Change History (7)

by SF/boneosaurusrex, 6 years ago

Attachment: laurabow2.005 added

comment:1 by Strangerke, 6 years ago

Component: Engine: SCI
Game: Laura Bow 2: The Dagger of Amon-Ra

comment:2 by m-kiewitz, 6 years ago

Hi,

You are saying that in Laura Bow 2/CD the painting closes again when walking away. I can't reproduce that for the CD version using Sierra SCI. For me the painting only gets closed, when I leave the room and enter it again. You are using the plain CD version without any patches applied?

I'm using DOS-Box using 3000 cycles.

When playing Laura Bow 2/Floppy however the painting closes when leaving the original position (like you said). The code responsible for this was removed from Laura Bow 2/CD. The floppy version actually checked the exact position of ego (Laura Bow).

comment:3 by SF/boneosaurusrex, 6 years ago

I just re-tested and you're right, the painting stays open in all scenarios on the CD version. Sorry about that! I must have been mistaken about which version dosbox was running during that test. And here I was trying to keep things from getting more confusing...

So that simplifies this down to just two differences in the floppy version between ScummVM and Sierra SCI:

  1. In ScummVM the you get stuck (and the safe closes) when Wolf boots you
  2. In ScummVM the safe stays open when walking away

Thanks for looking into this! You guys are heroes... I may have a tiny major crush on this project.

comment:4 by m-kiewitz, 6 years ago

I think I just fixed the safe issue by script patch. Floppy works correctly without the script patch. Only the CD version needs patching and the CD bug is actually a script bug, which also occurs in DOS-Box, when you turn up the cycles.

It seems the other issue is a path-finding problem (off-by-1). We had a few of those issues, because the pathfinding is not exactly the same as in Sierra SCI.

Please check, if it's now working correctly.
Partly fixed by commit #1454408e96641beecaf3021e9ce4fedf01bce7c3

comment:5 by SF/boneosaurusrex, 6 years ago

All is now working as expected, thanks! The safe's behavior in both floppy and CD versions now matches Sierra SCI's behavior, and more importantly, ego no longer gets stuck in the floppy version.

So as far as I can tell, from the player's perspective this appears 100% fixed. Thank you again!

comment:6 by m-kiewitz, 6 years ago

Keywords: original added
Owner: set to m-kiewitz
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.