Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#6153 closed defect (fixed)

SCI: QFG3: gog patches identified as fan patches

Reported by: SF/captainjei Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: script Cc:
Game: Quest for Glory 3

Description

gog.com recently updated their Quest for Glory installer. When starting their version for Quest for Glory 3, this message appears: "Your game is patched with a fan made script patch. Such patches have been reported to cause issues, as they modify game scripts extensively. The issues that these patches fix do not occur in ScummVM, so you are advised to remove this patch from your game folder in order to avoid having unexpected errors and/or issues later on."

ScummVM version: 1.6.0git1859-g8335e34 (Oct 4 2012 10:23:47)
Game language: English
Game version: floppy version 1.1 (most recent gog.com version)
Platform: Windows 7

Ticket imported from: #3574541. Ticket imported from: bugs/6153.

Change History (5)

comment:1 Changed 7 years ago by wjp

One particularly important effect of the NRS patch GOG applies is fixing combat timing. Without this patch, combat is incredibly easy because you move many times faster than monsters.

We may have to re-evaluate these patches.

comment:2 Changed 7 years ago by bluegr

Well, these patches are fan made, not officially released by Sierra. My main concerns are that these patches hack scripts in unexpected ways (e.g. trying to get the absolute value of an object by invoking abs() on it). Some of them make the games unplayable and cause them to crash. Check this bug, for example:
https://sourceforge.net/tracker/?func=detail&aid=3077086&group_id=37116&atid=418820

comment:3 Changed 7 years ago by SF/captainjei

Would there be any way to get ScummVM to ignore the NRS patches? As far as I know, the gog.com version of Quest for Glory 3 is the only new copy one can legally buy, and the patches now come included by default. When I set it up to play and was told by ScummVM that I should remove the patches, I had no idea which patch files were NRS's and which were Sierra's.

comment:4 Changed 6 years ago by bluegr

Fixed the incorrect detecion of NRS patches in QFG3 in commit 99e90b9

As for the other bug (fast hero's actions), there's a separate bug report filed in bug #3604938:
https://sourceforge.net/tracker/?func=detail&aid=3604938&group_id=37116&atid=418820

Closing this one as fixed

comment:5 Changed 6 years ago by bluegr

Component: Engine: SCI
Game: Quest for Glory 3
Keywords: script added
Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.