#5907 closed defect (fixed)
MAEMO: Zoom keybindings don't work well on maemo N900 port
| Reported by: | SF/nerdknight | Owned by: | tsoliman |
|---|---|---|---|
| Priority: | normal | Component: | Port: Maemo |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
The keybindings on the zoom keys doesn't work quite well, the still control the system volume, but after a while switching between applications they worked. Scummvm version: 1.5.0git812-gc451bd4-dirty (Nov 24 2011 23:42:16)
The problem may be the same as described in the following link: http://maemo.org/community/maemo-developers/howto_grab_all_maemo5_zoom_key_events_in_sdl-sdl_gles_app/?org_openpsa_qbpager_net_nemein_discussion_posts_page=1#50222922577d11df807a8707c62511b011b0
Ticket imported from: #3443037. Ticket imported from: bugs/5907.
Attachments (1)
Change History (14)
comment:1 by , 12 years ago
| Owner: | set to |
|---|
comment:2 by , 12 years ago
| Summary: | Zoom keybindings don't work well on maemo N900 port → MAEMO: Zoom keybindings don't work well on maemo N900 port |
|---|
by , 12 years ago
| Attachment: | zoomKeysPatch.patch added |
|---|
comment:3 by , 12 years ago
Can you see if it works in the following cases
- Quit and Start scummvm with the fullscreen option checked (scummvm starts in fullscreen). TEST! - Switch to windowed mode using the fullscreen key. TEST! - Quit and Start scummvm with the fullscreen option unchecked (scummvm starts in windowed mode). TEST! - Switch to fullscreen mode using the fullscreen key. TEST!
The best key to test would be the one that switches clicking mode since it displays an OSD message.
comment:4 by , 12 years ago
As you may have known already, I don't have a physical N900 so testing/fixing this will be tricky and I will need your help with it.
comment:5 by , 12 years ago
| Component: | --Unset-- |
|---|---|
| Resolution: | → fixed |
| Status: | new → pending |
comment:8 by , 12 years ago
| Status: | pending → new |
|---|
comment:9 by , 12 years ago
I tested your build with the cases you mentioned, the only problems I found are: -When starting ScummVM with fullscreen unchecked, the first button press triggers the volume function, but after that one it works as it should -N900 doesn't have fullscreen button, so I made the tests using the fullscreen checkbox in options
Another thing: when using ScummVM not in fullscreen, the bottom part of the screen appers cutted off because of the system's menu on top, turnning the app almost unusable for most games, shall I repport a bug for this?
comment:10 by , 12 years ago
| Status: | new → closed |
|---|
comment:11 by , 12 years ago
Thanks for testing.
> When starting ScummVM with fullscreen unchecked, the first button press triggers the volume function, but after that one it works as it should
This is considered fixed IMO then. It was something that the old 1.2.1 port code was doing that I neglected implementing in the 1.4.0 port rewrite.
> Another thing: when using ScummVM not in fullscreen, the bottom part of the screen appers cutted off because of the system's menu on top, turnning the app almost unusable for most games, shall I repport a bug for this?
This is normal. There isn't enough room (pixels in the display) for the whole window because of the title-bar, and the port is not using OpenGL so the window cannot be arbitrarily scaled. One should run scummvm always in fullscreen on maemo devices anyway. I don't want to take away the ability to switch to windowed mode, though.
> N900 doesn't have fullscreen button, so I made the tests using the fullscreen checkbox in options
Ah yes, I forgot about that. The N800 has one but it doesn't have enough keys (no CTRL key) so its fullscreen hardware key is bound to another function.
Thanks again for testing this and please continue to test and report other N900 issues you find.
comment:12 by , 5 years ago
| Component: | → Ports |
|---|
comment:13 by , 5 years ago
| Component: | Ports → Port: Maemo |
|---|
This patch solves the problem, it's made out of version 1.4.0, it includes also the keyevents patch. I took the patch from the version from maemo repositories.