Opened 8 years ago

Closed 8 years ago

#5717 closed defect (fixed)

TOON: Crashes

Reported by: SF/patryn Owned by: sylvaintv
Priority: normal Component: Engine: Toon
Keywords: Cc:
Game: Toonstruck

Description

For a while I have been experiencing non-deterministic crashes that I could not reliably reproduce, the only thing they had in common was that the cursor was always the "magnifying lens" when the game crashed.
However finally I have a save game that can reproduce this every time. Just move the cursor to the top of the screen above the prison cell.

Running the daily build of 19/05/11, happens on Android, does not seem to happen on Windows.

Ticket imported from: #3308220. Ticket imported from: bugs/5717.

Attachments (3)

toon.012 (21.8 KB ) - added by SF/patryn 8 years ago.
toon-magnifier-valgrind.txt (11.3 KB ) - added by digitall 8 years ago.
Associated Valgrind Issues
toon_magnify_clipping.txt (1.7 KB ) - added by fuzzie 8 years ago.
hastily-written patch

Download all attachments as: .zip

Change History (8)

by SF/patryn, 8 years ago

Attachment: toon.012 added

comment:1 by digitall, 8 years ago

Owner: set to sylvaintv

comment:2 by digitall, 8 years ago

No crash with Linux x86_32 on:
ScummVM 1.4.0git591-gff62a60-dirty (May 27 2011 15:10:57)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib FluidSynth Theora

But running with Valgrind shows a number of invalid reads and more importantly writes associated with GFX and magnifier effect. Attaching traces.

by digitall, 8 years ago

Attachment: toon-magnifier-valgrind.txt added

Associated Valgrind Issues

comment:3 by fuzzie, 8 years ago

I tried clipping both the source and destination -- but this means you get double pixels right at the edges, so while valgrind is happy and this probably fixes the reported crash, I'll attach a patch rather than committing it.

by fuzzie, 8 years ago

Attachment: toon_magnify_clipping.txt added

hastily-written patch

comment:4 by sylvaintv, 8 years ago

Resolution: fixed
Status: newclosed

comment:5 by sylvaintv, 8 years ago

fixed in r3429a14

Note: See TracTickets for help on using tickets.