Opened 8 years ago

Closed 8 years ago

#5657 closed defect (fixed)

HUGO: Whodunit? and Jungle of Doom don't survive the intro

Reported by: raziel- Owned by: Strangerke
Priority: normal Component: Engine: Hugo
Keywords: Cc:
Game: Hugo

Description

ScummVM 1.3.0git (Apr 22 2011 19:52:50)
Features compiled in: Vorbis FLAC MP3 RGB zLib Theora

While the intro rolls right after the first character is drawn before the house i get a
Fetched string too long!!
and the console pops up.
Playing is not possible as all the options that wiould restart the game will quit ScummVM instead.

Hugo 2: Whodunit? (DOS/English)

AmigaOS4 - PPC - SDL - BE
gcc (GCC) 4.2.4 (adtools build 20090118)

Ticket imported from: #3291573. Ticket imported from: bugs/5657.

Change History (11)

comment:1 by digitall, 8 years ago

Can't replicate on Linux x86_32.

raziel_ : Could you please repeat this with "./scummvm -d 5 --debugflags=File" and report the last "fetchstring(<value>)" prior to the error exit.

comment:2 by digitall, 8 years ago

Owner: set to Strangerke

comment:3 by wjp, 8 years ago

fetchString uses _stringArchive.read((char *)&off1, sizeof(uint32)) to read uint32s, which isn't endian-safe. It should probably be using _stringArchive.readUint32LE().

comment:4 by raziel-, 8 years ago

scummvm -d 5--debugflags=File

...
readOverlay(0, ...)
fetchString(6)
Fetched string too long!!

comment:5 by raziel-, 8 years ago

Hugo 3 is affected aswell

...
readOverlay(0, ...)
fetchString(120)
Fetched string too long!!

comment:6 by raziel-, 8 years ago

Summary: HUGO: Whodunit? doesn't survive the introHUGO: Whodunit? and Jungle of Doom don't survive the intro

comment:7 by Strangerke, 8 years ago

Resolution: fixed

comment:8 by Strangerke, 8 years ago

H2 Dos and H3 Dos are using the same fetchString() function, and wjp most certainly identified the problem. I committed a fix, Could you check if it works properly now?

comment:9 by raziel-, 8 years ago

Yes, fixed and working, thanks

comment:10 by Strangerke, 8 years ago

Fixed in 8651f9739f20c1a3cb70

comment:11 by Strangerke, 8 years ago

Status: newclosed
Note: See TracTickets for help on using tickets.