SCI32: KQ7 coordinates bug
|Reported by:||SF/vakons||Owned by:||SF/mthreepwood|
|Cc:||Game:||King's Quest 7|
Bug appeared in SVN revision 55744. ( http://scummvm.svn.sourceforge.net/viewvc/scummvm?view=revision&revision=55744 )
Logic was changed (in 5 places) in engines\sci\graphics\frameout.cpp, view.cpp and compare.cpp.
If I got it right, check for SCI_VERSION_2 was removed before checking "view->isSci2Hires()".
was: 2.0.hi UpscaledCoordinates 2.0 - 2.1.hi screen / script 2.1 screen / script x.x.hi - x.x -
now: 2.0.hi UpscaledCoordinates 2.0 - 2.1.hi UpscaledCoordinates 2.1 screen / script x.x.hi UpscaledCoordinates x.x -
In King's Quest VII (SCI v2.1) this causes incorrect coordinates handling (from SCI v2.0?), because some of game objects returns view->isSci2Hires() == true.
(For example, "Corn Kernel" and "Ear of Corn", when they are being examined in 3D window, or "Ripped Petticoat", when it's taken from cactus).
As a result, objects are placed with wrong coordinates, in addition their hotspots are somewhere outside.
By the way, that patch affects everything but 2.0 games, which Gabriel Knight 1 should be, according to http://wiki.scummvm.org/index.php/Sierra_Game_Versions#SCI_Games . And it tries to handle v2.1 as v2.0. So maybe Mac version is incorrectly detected as v2.1?
Sorry if I messed something up, I don't know much about SCI interpreters yet. :)
Ticket imported from: #3253208. Ticket imported from: bugs/5615.