Opened 9 years ago

Closed 9 years ago

#5400 closed defect (fixed)

SCI: Magnifier cursor

Reported by: SF/philohippus Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Laura Bow 2: The Dagger of Amon-Ra

Description

Laura Bow 2: The Dagger of Amon Ra (CD/DOS/English), version 1.1
ScummVM 1.2.0svn53003

This is a follow up on bug 3034973 which was recently closed.
The Magnifier cursor is working but not very well:

Tested with Laura Bow 2, room 454:
1. The magnification is not properly aligned with the underlying graphics. Even if it were not visually confusing, this leads to the inability to scan the whole magnified graphic as it is larger than the allotted cursor area. I'm guessing the magnified graphic should be displaced in a direction opposite to the cursor motion in order to keep the magnified graphics aligned with the graphics below.
2. Magnification is too high.
3. The z index of the cursor is too high, it should appear below the center frame.
4. The smaller cursor area is not very elegantly imposed, the cursor seems to be pushed back from the boundary instead of actually hitting the boundary.

Ticket imported from: #3080639. Ticket imported from: bugs/5400.

Attachments (4)

laurabow2.012 (51.2 KB) - added by SF/philohippus 9 years ago.
Savegame
DosBox.PNG (39.4 KB) - added by SF/philohippus 9 years ago.
dosbox screenshot
ScummVM.PNG (61.6 KB) - added by SF/philohippus 9 years ago.
scummvm screenshot
freddypharkas.000 (62.7 KB) - added by bluegr 9 years ago.
Attached Freddy Pharkas savegame from bug report #3034973

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by SF/philohippus

Attachment: laurabow2.012 added

Savegame

Changed 9 years ago by SF/philohippus

Attachment: DosBox.PNG added

dosbox screenshot

Changed 9 years ago by SF/philohippus

Attachment: ScummVM.PNG added

scummvm screenshot

comment:1 Changed 9 years ago by SF/philohippus

Room 454 does not allow saving so from the savegame point, walk left, use magnifying glass on left wall.

comment:2 Changed 9 years ago by bluegr

Could you recheck? Most of the issues should be gone now (at least 1, 2 and 3). 4 needs a bit further work

comment:3 Changed 9 years ago by SF/kuroshiro

Just wanted to report that this acts a bit strangely in Freddy Pharkas (r53011). I have had 3 things happen, playing through this sequence 3 times:

The first time, ScummVM simply crashed to desktop. The 2nd time, the magnifier cursor showed basically gibberish graphics, white on a black BG. The third time (reloading a game) the magnifier worked properly.

comment:4 Changed 9 years ago by SF/philohippus

It's much better indeed, the major problem is gone as it now permits scanning the whole magnified graphic. However:

Build 53014:
1. There's still a bit of misalignment, all magnified graphics appear to need a bit of downwards offsetting. To test accurately, align center of magnifier rim beside some underlying feature of your choice, then slide magnifier sideways into the feature. Center of magnifier circle should be aligned.
3. I still have the cursor appearing above the decorative frame.
5. (NEW) As the graphics are now all visible it is now apparent that the outer edges of the magnification graphics freeze when moving the cursor outwards beyond them. Magnifier should leave the graphics behind and show only black.

Changed 9 years ago by bluegr

Attachment: freddypharkas.000 added

Attached Freddy Pharkas savegame from bug report #3034973

comment:5 Changed 9 years ago by bluegr

The remaining issues have been fixed with rev 53071, apart from 4, which would require a rewrite of the current code. Sierra used a picture which followed an invisible cursor, whereas we change the cursor itself.

Anyway, this isn't a major problem, just a slight glitch with the current implementation, plus there's a relevant TODO in the code in case someone wants to do this the way Sierra did. Thus, I'm closing this

comment:6 Changed 9 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.