Opened 9 years ago

Closed 9 years ago

Last modified 13 months ago

#5344 closed defect (fixed)

i18n: Translations are not found

Reported by: sev- Owned by: criezy
Priority: blocker Component: GUI: Translations
Keywords: Cc:
Game:

Description

Currently there is no way to specify where translations.dat file has to be kept. Ideally it should be put in same directory where GUI themes are.

Ticket imported from: #3062612. Ticket imported from: bugs/5344.

Change History (10)

comment:1 by sev-, 9 years ago

Raising priority. This is a release-critical bug.

comment:2 by sev-, 9 years ago

Priority: normalblocker
Summary: Translations are not foundi18n: Translations are not found

comment:3 by Kirben, 9 years ago

Why should a path even need to be set for the translation file? it is a single file, that a user shouldn't need to change.

The file should be stored in the same location, at the other game engine data files.

comment:4 by criezy, 9 years ago

I committed a change about a week ago so that the translations.dat file is found if it is in the Theme Path. The code is actually very similar to the code in the ThemeEngine and it works for me. However I only tested it on MacOS X (without a bundle since it was already working with an application bundle before).

comment:5 by lordhoto, 9 years ago

I can tell that it works just fine in the CWD and themepath for me. I guess it should be fine with DATA_DIR (and all default setup paths in our SearchMan) too.

I am not sure whether it is accepted in extrapath currently. I don't see this as a real bad thing, but since we allow themes to be present in extrapath too, it might be nice to check extrapath for translations.dat too.

comment:6 by criezy, 9 years ago

It is indeed not currently accepted in extrapath. But are you sure that themes are accepted in extrapath? I didn't see it in the code and I just tested and my ScummVM cannot find themes in the extrapath,

What I have seen in the code for the theme is that it uses the SearchMan and also look in the themepath and its sub-directories. This is what is done for the translation.dat file as well. So it seems to me that if ScummVM can find the scummmodern theme it should also find the translation.

comment:7 by lordhoto, 9 years ago

Actually in the past there was code for that. It was probably removed.

In any case I am not sure why we still have this report open though, I mean it's recognized in the default setup paths and themepath right now, right? Or is this report rather about making the code easier to adapt for a new location (wild guess)?

comment:8 by sev-, 9 years ago

Owner: set to criezy
Resolution: fixed
Status: newclosed

comment:9 by sev-, 9 years ago

Yes, I just checked the code it is suitable.

comment:10 by digitall, 13 months ago

Component: GUI: Translations
Note: See TracTickets for help on using tickets.