Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4893 closed defect (fixed)

Crash when using smacker cutscenes

Reported by: SF/kolthor Owned by: SF/mthreepwood
Priority: normal Component: Engine: Sword1
Keywords: Cc:
Game: Broken Sword 1

Description

Error message:
Assertion failed: isStereo == _header.audioInfo[streamNum].isStereo, file graphics/video/smk_decoder.cpp, line 765

Versions:
1.0.0rc1 and up to at least 1.1.148874

Language:
English (UK)

Game version:
CD - "Total Revolution: the Complete Adventure" http://www.amazon.co.uk/Total-Revolution-the-Complete-Adventure/dp/B000050NSB

Platform:
Win32

Steps to reproduce:
Start a new game, with original smk curscenes, the opening cutscene immediately crashes ScummVM

Ticket imported from: #3009282. Ticket imported from: bugs/4893.

Change History (5)

comment:1 by SF/kolthor, 9 years ago

It may be an issue with the Intro.smk from that compilation version - that cutscene was modified compared to the original.

I tried attaching the HQ one (from Smackshi), but no file was attached. I guess it was too large.
You can download them from my webserver in stead:

http://kolthor.dyndns.dk/secret/Broken_Sword/SMACKSHI/Intro.smk
http://kolthor.dyndns.dk/secret/Broken_Sword/SMACKSLO/Intro.smk

comment:2 by SF/mthreepwood, 9 years ago

Try with a daily build, this should have been fixed with r49340.

comment:3 by SF/kolthor, 9 years ago

Just tried r49354, and I still get the same error.

I got a few warning messages too though, so it seems like the change you made did something:

code: User picked target 'sword1' (gameid 'sword1')...
Looking for a plugin supporting this gameid... Broken Sword
Starting 'Broken Sword: The Shadow of the Templars'
WARNING: Unhandled Smacker v2 audio compression!
WARNING: Unhandled Smacker v2 audio compression!
WARNING: Unhandled Smacker v2 audio compression!
WARNING: Unhandled Smacker v2 audio compression!
WARNING: Unhandled Smacker v2 audio compression!
WARNING: Unhandled Smacker v2 audio compression!
Assertion failed: isStereo == _header.audioInfo[streamNum].isStereo, file graphics/video/smk_decoder.cpp, line 750

comment:4 by SF/mthreepwood, 9 years ago

Fixed the crash in r49362, but the audio (in this case, Bink RDFT) is still not supported. Adding the audio support to the TODO list. Thanks to digitall for help in tracking down the full cause.

Note: Don't forget that the first several seconds of the intro video are audio only, so don't think that the video's not playing at that point ;)

comment:5 by SF/mthreepwood, 9 years ago

Owner: set to SF/mthreepwood
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.