Opened 10 years ago

Closed 8 years ago

#4774 closed defect (fixed)

MADE: Screen effects sometimes look wrong/bad

Reported by: eriktorbjorn Owned by: johndoe123
Priority: high Component: Engine: MADE
Keywords: Cc:
Game: Return to Zork

Description

Current ScummVM SVN
I've verified it with the English version of Return to Zork, but I guess any supported version will do

The screen effects in the MADE engine were modified to run on low-end hardware. However, the result doesn't always look as good as the original behaviour. Here's a slow-motion comparision I made:

http://www.update.uu.se/~d91tan/ScummVM/rtz.html

It would be nice if we could both look good on "normal" hardware, while still playing nice on low-end hardware. Possibly by introducing a compile- or runtime setting.

This was discussed on scummvm-devel recently, but nothing was decided. The discussion can be read here:

http://sourceforge.net/mailarchive/message.php?msg_name=SNT118-W13FFC8054BD281DC78A1B3AE590%40phx.gbl

Ticket imported from: #2957333. Ticket imported from: bugs/4774.

Attachments (1)

made.patch (13.0 KB ) - added by johndoe123 9 years ago.
Patch for screen effects

Download all attachments as: .zip

Change History (10)

comment:1 by eriktorbjorn, 9 years ago

Raising priority to "nice to have fixed for 1.2.0".

I'm doing this because to me the bug is pretty darn noticeable, and we already have the correct behavior implemented. It just happened to be too slow on some low-end platforms.

comment:2 by eriktorbjorn, 9 years ago

Priority: lowhigh

by johndoe123, 9 years ago

Attachment: made.patch added

Patch for screen effects

comment:3 by johndoe123, 9 years ago

I've added a patch with a possible fix. It does what the fade in/out effect already did, that is it does reduce the number of palette updates. It looks pretty close to the original but needs fewer palette updates.
I didn't commit it right away since I wanted to hear from porters of "slow" platforms first if the effects are fast enough or slow again.
Any comments are welcome.

comment:4 by eriktorbjorn, 9 years ago

It looks promising, but I only have a fairly fast desktop computer to test it on.

One thing I noticed is that the patch doesn't seem to do anything about vfx09(). But even using the supposedly original behaviour for it doesn't seem to match what I see in DOSBox. The colours in ScummVM seem a bit more... I don't know, random. (Also there seem to be some missing effects in ScummVM. E.g. when arriving at the lighthouse door, there's a transition both at the beginning and the end of the brief cutscene movie. In ScummVM, there's only one at the end. This may be getting off-topic though.)

comment:5 by sev-, 9 years ago

This bug is nice to get fixed before the release. Raising priority for keeping the track.

comment:6 by bluegr, 8 years ago

Applied patch in r8c431e1

comment:7 by bluegr, 8 years ago

Owner: set to bluegr

comment:8 by bluegr, 8 years ago

Owner: changed from bluegr to johndoe123
Resolution: fixed
Status: newclosed

comment:9 by bluegr, 8 years ago

After talking with erikborbjorn, it seems that the bug is fixed now after applying johndoe's patch. Closing

Note: See TracTickets for help on using tickets.