Opened 17 years ago

Closed 17 years ago

#474 closed defect (fixed)

ZAK256: inventory arrow covers item

Reported by: SF/martingu Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Zak McKracken

Description

- ScummVM version: Sep23 Daily Snapshot Win32 - Language of game: English - Version of game: FMTowns

the inventory item covers the leftmost pixels from the inventory items (savegame .s08 added). This didn't occur up to the Sep19 build. First time noticed in the Sep23 build but hadn't the possibility to test the sep21 build.

The savegame attached should show the bug. The word book is covered partially by the inventory arrow.

Ticket imported from: #613109. Ticket imported from: bugs/474.

Attachments (1)

zak256.s08 (33.2 KB ) - added by SF/martingu 17 years ago.
inventory partially covered by up/down arrow

Download all attachments as: .zip

Change History (7)

by SF/martingu, 17 years ago

Attachment: zak256.s08 added

inventory partially covered by up/down arrow

comment:1 by fingolfin, 17 years ago

I guess you meant to say: "the inventory arrow covers..." ? In that case, this might be related to a similar problem in monkeyvga: when you are on Melee island and "fighting" with pirates, there are two little arrows used to scroll thru the possible insults, and they also cover the leftmost part of the choice list.

comment:2 by SF/martingu, 17 years ago

yep, that sentence is meant to be the way you guessed. the summary has the right meaning nonetheless :-)

comment:3 by SF/khalek, 17 years ago

this behaviour also occurs in indy3

comment:4 by fingolfin, 17 years ago

I checked in a partial fix for the problem in Zak. Dunno about Indy3. Problem is still there in MIVGA (and apparently has a different cause there).

In a nutshell, the arrows are just text (i.e. special entries in the font, char 3 and 4), and for some reasons their width is calculated incorrectly, causing the overlap. I changed it to return the correct width in Zak256 only. I can enabled the hack for Indy3, too, if somebody provides me with a save game where I can test this :-)

comment:5 by SF/khalek, 17 years ago

updated the fix to include chr 1 & 2 (up arrow) and to be enabled for indy. the getSpacing function itself was intially quite a large hack that included a switch statement that specified spacing for different chars, so I could see how something like this could slip through.

can this be closed now?

comment:6 by fingolfin, 17 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.