Opened 18 years ago

Closed 18 years ago

#404 closed defect (fixed)

Fix for #591678 broke Loom

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

Revision 1.107 of actor.cpp (fix for #591678) broke Loom for me. I can no longer interact with the sleeping boy, Rusty Nailbender.

I don't know enough about this part of the code to be able to diagnose it, but here's some data which may possibly be helpful.This is what happens when I click on the boy with the old, working code:

adjustXYToBeInBox(311, 90, 8) => { 310, 81, 8 } adjustXYToBeInBox(311, 90, -1) => { 310, 81, 8 }

And with the new, broken code:

adjustXYToBeInBox(311, 90, 8) => { 310, 81, 8 } adjustXYToBeInBox(311, 90, -1) => { 311, 88, 10 }

This is what the debugger has to say on the subject of boxes:

Walk matrix: [0] [0] [0] [1] [12] [1] [0] [0] [0] [1] [1] [1] [2] [12] [2] [0] [1] [1] [2] [2] [2] [3] [3] [12] [4] [11] [4] [12] [12] [12] [0] [2] [12] [3] [3] [3] [4] [12] [12] [0] [3] [2] [4] [4] [4] [5] [9] [5] [10] [11] [10] [12] [12] [2] [0] [4] [4] [5] [5] [5] [6] [6] [6] [7] [9] [7] [10] [11] [10] [12] [12] [4] [0] [5] [5] [6] [6] [6] [7] [9] [7] [10] [12] [5] [0] [5] [5] [6] [6] [6] [7] [7] [7] [8] [9] [8] [10] [12] [5] [0] [7] [7] [8] [8] [8] [9] [9] [9] [10] [12] [7] [0] [8] [8] [9] [9] [9] [10] [12] [8] [0] [4] [4] [5] [9] [5] [10] [10] [10] [11] [11] [11] [12] [12] [4] [0] [10] [10] [11] [11] [11] [12] [12] [10] [0] [2] [2] [3] [3] [3] [4] [11] [2] [12] [12] [12]

Walk boxes: 0: [10 x 5] [64 x 74] [10 x 5] [64 x 74], flags=0x01, mask=1 1: [64 x 74] [79 x 78] [64 x 74] [79 x 78], flags=0x00, mask=1 2: [96 x 93] [153 x 93] [79 x 78] [117 x 78], flags=0x00, mask=0 3: [72 x 106] [96 x 106] [72 x 106] [96 x 106], flags=0xa0, mask=0 4: [153 x 93] [244 x 88] [153 x 93] [244 x 88], flags=0x00, mask=0 5: [246 x 82] [244 x 88] [246 x 82] [244 x 88], flags=0x00, mask=1 6: [246 x 64] [246 x 82] [246 x 64] [246 x 82], flags=0x80, mask=1 7: [246 x 82] [298 x 82] [246 x 82] [298 x 82], flags=0x00, mask=1 8: [298 x 82] [333 x 79] [298 x 82] [333 x 79], flags=0x00, mask=1 9: [333 x 79] [378 x 134] [333 x 79] [378 x 134], flags=0x01, mask=1 10: [244 x 88] [336 x 88] [244 x 88] [336 x 88], flags=0x80, mask=0 11: [336 x 88] [384 x 88] [336 x 88] [384 x 88], flags=0x80, mask=0 12: [96 x 93] [96 x 106] [131 x 93] [132 x 93], flags=0x00, mask=0

Ticket imported from: #594920. Ticket imported from: bugs/404.

Change History (7)

comment:1 by fingolfin, 18 years ago

Owner: set to fingolfin

comment:2 by eriktorbjorn, 18 years ago

This isn't the only thing that broke in Loom, by the way. It just happened to be the first thing that I noticed, and the only one I've tried looking into myself. (That was before I realized it was too complex for me. :-)

comment:3 by fingolfin, 18 years ago

This should be fixed in CVS now. Note that the boxflags internally changed, so save games might still be affected. Leaving a room and re-entering will fix the boxflags, though.

Please verify.

comment:4 by fingolfin, 18 years ago

Resolution: fixed
Status: newpending

comment:5 by eriktorbjorn, 18 years ago

Status: pendingnew

comment:6 by eriktorbjorn, 18 years ago

Everything seems to be all right now. Thanks!

comment:7 by fingolfin, 18 years ago

Status: newclosed
Note: See TracTickets for help on using tickets.