Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3654 closed defect (fixed)

ELVIRA1: Amiga crashes (paula.h:108)

Reported by: SF/bloody_noob Owned by: cyxx
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Elvira 1

Description

Subject:
Elvira - The Mistress of Dark causes a crash just at the beginning when you enter the castle and the guard (to your left) gets you for a chatter (That is before the Intro where you talk to Elvira for the first time).

Version:
ScummVM 0.11.1 (Mar 12 2008 14:17:57)
scummvm-20080316_unstripped (daily-build)

Language:
German, english

Version:
Amiga ( http://ubuntuusers.de/paste/113675/#code-l24 )

System:
Ubuntu 7.10 Gutsy Gibbon (self-compiled with GCC)
WindowsXPsp2 (pre-compiled)

Error:
File 333.out not found
File 393.out not found
File 723.out not found
File 383.out not found
(These files do not exist on my original german copies)

./sound/mods/paula.h:108: void Audio::Paula::setChannelData(uint8, const int8*, const int8*, uint32, uint32, int32): Assertion `0 <= offset && offset < 32768' failed.

Code near line 108 in paula.h:
00106 // For now, we only support 32k samples, as we use 16bit fixed point arithmetics.
00107 // If this ever turns out to be a problem, we can still enhance this code.
00108 assert(0 <= offset && offset < 32768);

Ticket imported from: #1915657. Ticket imported from: bugs/3654.

Attachments (2)

8tune (36.0 KB) - added by Kirben 11 years ago.
Module
1915657.diff (521 bytes) - added by cyxx 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by SF/bloody_noob

Summary: ELVIRA1 Amiga crashesELVIRA1: Amiga crashes (paula.h:108)

comment:2 Changed 11 years ago by fingolfin

My guess would be that the missing files are harmless/normal. The real issue is that it crashes in the Paula sound chip emulation code, which is used for MOD playback.

Kirben, any ideas?

comment:3 Changed 11 years ago by fingolfin

Owner: set to Kirben

comment:4 Changed 11 years ago by SF/bloody_noob

Iam not sure it may help but Elvira2 and Waxworks (Amiga) seem to work properly. I didn`t test it very far but at least I was able to walk around and do some fighting without a crash.

Changed 11 years ago by Kirben

Attachment: 8tune added

Module

comment:5 Changed 11 years ago by Kirben

Those file not found messages can be ignored, as not every zone uses sound files (*3.out).

That assert is triggered by an offset of 1985310, but I'm not sure what it causing that exact value.

I have attached the module, in case it can be used for testing. The module is packed, and can be manually unpacked by using extract_agos.
File Added: 8tune

Changed 11 years ago by cyxx

Attachment: 1915657.diff added

comment:6 Changed 11 years ago by cyxx

possible fix attached (Paula::setChannelData doesn't take a frac_t as its last arg).
File Added: 1915657.diff

comment:7 Changed 11 years ago by Kirben

Thanks, the patch solved the problem, and I committed patch to ScummVM 0.12.0svn.

comment:8 Changed 11 years ago by Kirben

Owner: changed from Kirben to cyxx
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.