Opened 12 years ago

Closed 11 years ago

Last modified 12 months ago

#3651 closed defect (fixed)

SWORD1: Save game naming inappropriate

Reported by: raziel- Owned by: bluegr
Priority: high Component: Engine: Sword1
Keywords: Cc:
Game: Broken Sword 1

Description

With all engines now featuring a custom naming of their
save games, only Broken Sword 1 stands out using the
general "SAVEGAME.00X" naming scheme.

Maybe this can be updated to use "sword1.00x" instead
as does Broken Sword 2 (sword2.00x)?

It may work with the same approach the NIPPON engine
changed their save game naming, see closed feature
request #1762620
http://sourceforge.net/tracker/index.php?func=detail&aid=1762620&group_id=37116&atid=418823

Ticket imported from: #1910871. Ticket imported from: bugs/3651.

Attachments (1)

sword1_save.patch (5.5 KB ) - added by lordhoto 12 years ago.
patch against current svn

Download all attachments as: .zip

Change History (12)

comment:1 by fingolfin, 12 years ago

Sounds quite sensible, yeah.

comment:2 by fingolfin, 12 years ago

Priority: normalhigh

comment:3 by fingolfin, 12 years ago

Likewise, SAVEGAME.INF should be changed to SWORD1.INF.

This is IMO a bug, not just a missing feature. Moving.

by lordhoto, 12 years ago

Attachment: sword1_save.patch added

patch against current svn

comment:4 by lordhoto, 12 years ago

I added an patch which makes the game using targetname.inf and targetname.XXX as files, it misses support for the old savegame.inf and savegame.xxx files though, I wonder if we should rename them (if so how?) or if no targetname.inf exists we should fall back to sword1.inf, that would require some changes then writing new saves then though, since all the old ones would have to be copied, so renaming sounds better when we want to support the old filenames.
File Added: sword1_save.patch

comment:5 by lordhoto, 12 years ago

Errr that should have been fall back to SAVEGAME.INF not sword1.inf.

comment:6 by fingolfin, 12 years ago

So I wonder, BS2 uses SWORD2.* for the savestate names, doesn't it? Are savestates between all versions of BS1 resp. BS2 interchangable? That would suggest using "SWORD1/2.inf". Else, "targetname.inf"

As for the fallback / migrating old savestates to the new system: So far we shared savestate between all versions of BS1 the user's got. To which would we migrate the old states? To the first one the user plays, I guess? This particular subproblem becomes non-existent if SWORD1.X is used as name, though.

comment:7 by lordhoto, 12 years ago

Looking at the code sword2 uses targetname.xxx too, at least so it looks like in engines/sword2/saveload.cpp ll53-58.

comment:8 by criezy, 12 years ago

To reply to fingolfun question, as far as I know the savestate are interchangable for all the versions of BS1 (at least I can interchange them between the Mac and the Windows versions that I have).
As a user I would probably prefer to have sword1 instead of targetname for the savefiles as I wouldn't have to rename the file depending on the version of BS1 I am using. But to be honnest I don't really see the point of starting the game with one version and continuing with another as I could'nt find any differences between the Mac and Windows version of the game.

comment:9 by bluegr, 11 years ago

This has been fixed with commits #35111, 35112

Closing

comment:10 by bluegr, 11 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:11 by digitall, 12 months ago

Component: Engine: Sword1
Game: Broken Sword 1
Note: See TracTickets for help on using tickets.