Opened 12 years ago

Closed 12 years ago

Last modified 13 months ago

#3580 closed defect (invalid)

GP2X: Missing File::exists() implementation

Reported by: bluegr Owned by: djwillis
Priority: normal Component: Port: GP2X
Keywords: Cc:
Game:

Description

File::exists() is a stub on the GP2X port. This affects all places where it's used and it also means that SAGA games won't work at all on this port, as the SAGA engine needs this function for detecting all the different versions of the games supported by it.

There have been relevant e-mails on -devel about this.

The function is defined (currently as a stub) in /backends/fs/gp32/gp32-fs.cpp

As mentioned by fingolfin, perhaps the old isValid() code can be reused for this function.

Relevant commits are:
#30597: implementation of exists() for the PSP port
#29327, 29328, 29329: implementation of exists() for the Amiga port
#28944: merge of the GSoC project, with major changes to the fs node

Assigning this to djwillis, as he's the GP2X port maintainer

Ticket imported from: #1875587. Ticket imported from: bugs/3580.

Change History (5)

comment:1 by sev-, 12 years ago

Summary: ALL: Missing File::exists() on GP2X portGP2X: Missing File::exists() implementation

comment:2 by djwillis, 12 years ago

thebluegr,

Maybe I am missing something but the GP2X port just (ab)uses the POSIX file system code and as such has a exists() that works just fine. I can say for sure that SAGA games work as many users have commented on playing IHNM on the GP2X in the 0.11.0 build ;-) (I can't test this myself being GP2X'less).

You refer in the ticket to /backends/fs/gp32/gp32-fs.cpp, this is the old GP32 backend that was formally discontinued in the 0.11.0 release as there is no one to maintain it (I used to maintain it, then WonStar took over, now it's dead unless someone steps up in the next release cycle).

I'll leave the ticket open until I get your comments just in case I am missing something obvious but I think this can be closed off as the bug does not exist on the GP2X.

John

comment:3 by bluegr, 12 years ago

Ah I didn't know that GP2X uses the POSIX file system, I thought it used the GP32 one

Since it's implemented and games are working correctly, I'll close this one as invalid

Thanks

comment:4 by bluegr, 12 years ago

Resolution: invalid
Status: newclosed

comment:5 by digitall, 13 months ago

Component: --Unset--Port: GP2X
Note: See TracTickets for help on using tickets.