Opened 16 years ago
Closed 16 years ago
Last modified 4 years ago
#3149 closed defect (fixed)
GUI/Win32: Error dialog changes window caption
|Reported by:||SF/clemty||Owned by:||eriktorbjorn|
ScummVM 0.10.0 Win32 Daily Build Apr 16
I tried starting Broken Sword 2 but I forgot to copy the CD.INF - an error dialog popped up, and the Window caption of the ScummVM program window changed to "Error".
On clicking ok the GUI/launcher appeared again, but the window caption still stated "Error" and did not reset to "ScummVM <version> <timestamp>"
Ticket imported from: #1701842. Ticket imported from: bugs/3149.
Change History (8)
comment:1 by , 16 years ago
by , 16 years ago
Patch against current SVN
comment:2 by , 16 years ago
Wouldn't it be simpler to just move the setWindowCaption(gScummVMFullVersion) call to the launcherDialog() function in base/main.cpp, like in the attached patch?
File Added: caption.diff
comment:3 by , 16 years ago
Torbjörn, looks good, just go ahead and commit that fix already ;)
comment:4 by , 16 years ago
comment:5 by , 16 years ago
comment:6 by , 16 years ago
|Status:||new → closed|
comment:7 by , 4 years ago
|Component:||→ Port: Win32|
Here's a fix for this error:
In file engines/engine.cpp, go to line 37 and add this line below it: #include "base/version.h" Then, go to line 179 and add this line below it: _system->setWindowCaption(gScummVMFullVersion);
I can't add files to bug reports from other people, so I can't submit a proper patch for it, but it's quite easy to fix this with these two changes.