Opened 13 years ago

Closed 13 years ago

#2960 closed defect (fixed)

GOB2: Notepad function doesn't work (auto closes on open)

Reported by: SF/adamhearn Owned by: DrMcCoy
Priority: normal Component: Engine: Gob
Keywords: Cc:
Game: Gobliins 2

Description

When selecting the Notepad facility in the game (accessible from the button bar at the top of the screen) it appears but then closes immediately.

Notepad function works as expected in DOSBox 0.65.

Gobliins 2 V1.01 from original release CD (although in game version shows V2.01!).

Platform: WinXP Pro (SP2, full Windows Update), Pentium-M 2Ghz, 2GB RAM,
GF6600GT (71.89), Audigy 2ZS (WBUP2_LB_2_09_0016)

Using configuration file: C:\Documents and Settings\Adam\Application Data\ScummV
M\scummvm.ini
ScummVM 0.10.0svn (Dec 22 2006 09:50:48)
Features compiled in: Vorbis FLAC MP3 zLib MPEG2

SCUMMVM.ini content:

[scummvm]
gfx_mode=hq3x
music_volume=255
midi_gain=100
speech_volume=100
browser_lastpath=C:\Games\ScummVM\Touche Demo\
aspect_ratio=true
music_driver=auto
lastselectedgame=gob2
native_mt32=false
gui_theme=modern
subtitles=true
fullscreen=false
sfx_volume=192
master_volume=255
talkspeed=60
speech_mute=false
enable_gs=false
multi_midi=false
versioninfo=0.10.0svn
savepath=C:\Games\ScummVM

[gob2]
description=Gobliins 2 (CD)
music_volume=192
midi_gain=100
speech_volume=192
path=C:\Games\ScummVM\Gobliins 2\
aspect_ratio=false
music_driver=auto
native_mt32=false
subtitles=false
gameid=gob2
fullscreen=false
sfx_volume=192
talkspeed=60
speech_mute=false
enable_gs=false
multi_midi=false

Ticket imported from: #1621089. Ticket imported from: bugs/2960.

Change History (12)

comment:1 Changed 13 years ago by sev-

Summary: Notepad function doesn't work (auto closes on open)GOB2: Notepad function doesn't work (auto closes on open)

comment:2 Changed 13 years ago by sev-

Owner: set to DrMcCoy

comment:3 Changed 13 years ago by DrMcCoy

Could you try again with the latest SVN version (or next daily build)? I should work now...

comment:4 Changed 13 years ago by bluegr

The bug is not 100% fixed

If you open the notepad the first time it works ok
If you type something, close it and reopen it it still works fine
But if you don't type anything and close it, you can't open it again unless you load a previous game, i.e. if the notepad is opened, you can't reopen it unless you typed something in it the first time

comment:5 Changed 13 years ago by bluegr

Follow-up:
The auto-closing of the notepad seems to be related with the cursor position
If the player clicks on the notepad icon the first time, it always works
The second time though, if the notepad icon is clicked then it auto-closes if it's empty AND the cursor is not moved from the notepad icon. If the player quickly clicks on the notepad icon and then quickly moves the mouse cursor to where the notepad will appear, the notepad shows correctly again. This happens in both Gobliins 2 AND Ween (ok, Ween is not officially supported yet, but the behavior of the notepad is exactly the same there, too)

comment:6 Changed 13 years ago by DrMcCoy

Could you try again with the latest SVN version / next daily build?

comment:7 Changed 13 years ago by DrMcCoy

...or rather try again now with the latest SVN version / next daily build. It seems there is a race condition in the script. When the notepad is opened and the mouse button is still pressed, it's closed again.
That didn't matter (or show up) in the orignal, since it took some time until the notepad was opened, a normal click was long finished then. Keeping the mouse button pressed will trigger it even with the original executable in Dosbox.
I've added a workaround, so it should work now...

comment:8 Changed 13 years ago by bluegr

I can confirm that the notepad is not working fine in Gobliins 2. However, opening the notepad in Ween will randomly exit the game without an error. Sometimes it works fine, sometimes the game just closes (yes yes I know it isn't supported yet).

You may close this, as it seems to be fixed for Gobliins 2. Should I submit a new bug report for Ween?

comment:9 Changed 13 years ago by bluegr

Er... sorry. Last message should read: "I can confirm that the notepad is working fine in Gobliins 2..."

comment:10 Changed 13 years ago by SF/adamhearn

Tested as working with 0.10.0svn (Feb 2 2007 20:28:32).

I'll defer setting the state to Closed until drmccoy has decided on course of bug action (new one for Ween or not!).

comment:11 Changed 13 years ago by sev-

Resolution: fixed
Status: newclosed

comment:12 Changed 13 years ago by sev-

Yes, please, always submit only one bug per report. I.e. 2 different games -- 2 reports. 2 bugs on one game, 2 bugreports as well.

Closing as fixed.

Note: See TracTickets for help on using tickets.