#2946 closed defect (fixed)
PSP: Unable to save games after changing save path via GUI
| Reported by: | SF/wichetael | Owned by: | joostp |
|---|---|---|---|
| Priority: | normal | Component: | Port: PSP |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
ScummVM version 0.9.1 PSP firmware 1.5
Save is not working if the save path ends in a '/', which is the case when selecting the save path through the GUI. After removing the '/' manually with a text editor saving games works fine.
Ticket imported from: #1615115. Ticket imported from: bugs/2946.
Change History (16)
comment:1 by , 17 years ago
| Owner: | set to |
|---|
comment:2 by , 17 years ago
comment:3 by , 17 years ago
I experienced the problem with dott, mm and atlantis
I installed the port to psp, changed the save path in the options not knowing it would be ignored. Started a game and found I could not save games. I tried setting various different paths from within the GUI and all failed as all had a trailing slash. After editing scummvm.ini manually and removing the trailing slash the save games can be made, but do go into the ms0:/scummvm_savegames directory. I don't see why the setting is ignored by the way, but that is another matter. But well, apparently it isn't completely ignored either.
comment:4 by , 17 years ago
Thanks, I will look into this when time permits, and will consider allowing the user to override the save path as well (but keeping ms0:/scummvm_savegames as the default)
comment:5 by , 17 years ago
| Summary: | PSP: Unable to save games → PSP: Unable to save games after changing save path via GUI |
|---|
comment:6 by , 17 years ago
Removing the trailing "/" doesn't solve the problem. I just removed it... having: savepath=ms0:/PSP/GAME/SCUMMVM/scummvm_savegames
No effect. It still gets ignored and a new savegame-directory gets created in the memorystick-root. :-( Would be nice if this could be fixed in any future version. Thanks.
comment:7 by , 17 years ago
| Status: | new → pending |
|---|
comment:9 by , 17 years ago
I've only briefly looked into this, but couldn't figure out why the bug would occur, as SaveFileManager::getSavePath() should ALWAYS return the hardcoded path on PSP. But I guess it uses some ConfMan setting somewhere instead?
Allowing the user to select/change the savepath is something that is planned for when I finally get time to do the backend restructuring that I've been wanting to do for some time now.
comment:10 by , 17 years ago
| Status: | pending → new |
|---|
comment:11 by , 17 years ago
Well I just search for "savepath" and it's only used in four files:
./backends/saves/savefile.cpp ./base/commandLine.cpp ./gui/launcher.cpp ./gui/options.cpp
And in each case this is perfectly ok: The first is the default getSavePath implementation, the second is for the --savepath command line option resp. the SCUMMVM_SAVEPATH env variable, and the last two are for the GUI code. So this seems indeed quite mysterious.
comment:14 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:16 by , 5 years ago
| Component: | --Unset-- → Port: PSP |
|---|
Hmm, strange. The PSP port should ignore whatever save path the user sets (whether via GUI or editing scummvm.ini directly) and instead save to a fixed location.
Does this happen with all games/engines? Also, can you tell me which steps are needed for reproducing this problem?